Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1891293002: Adds clearer function to create rtc::Thread without Physical SocketServer (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds clearer function to create rtc::Thread without Physical SocketServer Moves logic of default SocketServer from MessageQueue to SocketServer Committed: https://crrev.com/bebf54cad1b8c5156652a869305c7be9dc2e9ddc Cr-Commit-Position: refs/heads/master@{#12541}

Patch Set 1 #

Patch Set 2 : gn #

Patch Set 3 : year #

Total comments: 6

Patch Set 4 : feedback #

Patch Set 5 : rebase #

Total comments: 2

Patch Set 6 : rebase; move two Thread constructors to protected #

Total comments: 6

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -76 lines) Patch
M webrtc/base/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/messagequeue.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/base/messagequeue.cc View 1 2 3 3 chunks +13 lines, -23 lines 0 comments Download
M webrtc/base/messagequeue_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/base/nullsocketserver.h View 1 1 chunk +11 lines, -34 lines 0 comments Download
A webrtc/base/nullsocketserver.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M webrtc/base/physicalsocketserver.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/base/socketserver.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/base/thread.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/base/thread.cc View 1 2 3 4 5 6 7 5 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
danilchap
Most threads do not need PhysicalSocketServer. This CL adds function that allows creating Thread with ...
4 years, 8 months ago (2016-04-15 17:49:15 UTC) #2
stefan-webrtc
https://codereview.webrtc.org/1891293002/diff/40001/webrtc/base/messagequeue.cc File webrtc/base/messagequeue.cc (right): https://codereview.webrtc.org/1891293002/diff/40001/webrtc/base/messagequeue.cc#newcode115 webrtc/base/messagequeue.cc:115: // messagequeue_unittest to depend on network libraries... yuck. Is ...
4 years, 8 months ago (2016-04-19 08:29:33 UTC) #3
danilchap
https://codereview.webrtc.org/1891293002/diff/40001/webrtc/base/messagequeue.cc File webrtc/base/messagequeue.cc (right): https://codereview.webrtc.org/1891293002/diff/40001/webrtc/base/messagequeue.cc#newcode115 webrtc/base/messagequeue.cc:115: // messagequeue_unittest to depend on network libraries... yuck. On ...
4 years, 8 months ago (2016-04-19 09:43:10 UTC) #4
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-19 10:24:32 UTC) #5
danilchap
4 years, 7 months ago (2016-04-25 09:45:03 UTC) #7
perkj_webrtc
tommi might have comments on this class as well if you want. https://codereview.webrtc.org/1891293002/diff/80001/webrtc/base/thread.h File webrtc/base/thread.h ...
4 years, 7 months ago (2016-04-27 10:54:01 UTC) #8
tommi
I'm really liking this cl! Have a couple of questions but lgtm. https://codereview.webrtc.org/1891293002/diff/100001/webrtc/base/messagequeue.h File webrtc/base/messagequeue.h ...
4 years, 7 months ago (2016-04-27 12:45:25 UTC) #10
danilchap
https://codereview.webrtc.org/1891293002/diff/80001/webrtc/base/thread.h File webrtc/base/thread.h (right): https://codereview.webrtc.org/1891293002/diff/80001/webrtc/base/thread.h#newcode103 webrtc/base/thread.h:103: explicit Thread(SocketServer* ss); On 2016/04/27 10:54:01, perkj_webrtc wrote: > ...
4 years, 7 months ago (2016-04-27 15:08:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891293002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891293002/140001
4 years, 7 months ago (2016-04-28 08:25:47 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 7 months ago (2016-04-28 08:32:53 UTC) #15
pthatcher1
lgtm
4 years, 7 months ago (2016-04-29 22:56:35 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:09 UTC) #18
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/bebf54cad1b8c5156652a869305c7be9dc2e9ddc
Cr-Commit-Position: refs/heads/master@{#12541}

Powered by Google App Engine
This is Rietveld 408576698