Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1889463002: Remove field trial for scaling down MediaCodec. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove field trial for scaling down MediaCodec. This should be on everywhere. BUG=webrtc:5678 R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/7ace488f477a7e4cce77d5aaebbfe8c7327a425a

Patch Set 1 #

Total comments: 1

Patch Set 2 : add back scale_ flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pbos-webrtc
PTAL, this should be considered tested by now I think?
4 years, 8 months ago (2016-04-13 15:04:29 UTC) #1
AlexG
https://codereview.webrtc.org/1889463002/diff/1/webrtc/api/java/jni/androidmediaencoder_jni.cc File webrtc/api/java/jni/androidmediaencoder_jni.cc (right): https://codereview.webrtc.org/1889463002/diff/1/webrtc/api/java/jni/androidmediaencoder_jni.cc#newcode656 webrtc/api/java/jni/androidmediaencoder_jni.cc:656: const webrtc::QualityScaler::Resolution scaled_resolution = How this will work for ...
4 years, 8 months ago (2016-04-13 16:46:12 UTC) #2
pbos-webrtc
add back scale_ flag
4 years, 8 months ago (2016-04-13 21:49:39 UTC) #3
pbos-webrtc
PTAL, I added back bool scale_, so it shouldn't trigger for VP9 now.
4 years, 8 months ago (2016-04-13 21:50:27 UTC) #4
AlexG
lgtm
4 years, 8 months ago (2016-04-13 22:44:40 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7ace488f477a7e4cce77d5aaebbfe8c7327a425a Cr-Commit-Position: refs/heads/master@{#12355}
4 years, 8 months ago (2016-04-13 22:55:13 UTC) #7
pbos-webrtc
4 years, 8 months ago (2016-04-13 22:55:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7ace488f477a7e4cce77d5aaebbfe8c7327a425a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698