Delete method webrtc::VideoFrame::Reset.

webrtc/video/video_capture_input.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 66 matching lines @@
   rtc::CritScope lock(&crit_);
   if (incoming_frame.ntp_time_ms() <= last_captured_timestamp_) {
     // We don't allow the same capture time for two frames, drop this one.
     LOG(LS_WARNING) << "Same/old NTP timestamp ("
                     << incoming_frame.ntp_time_ms()
                     << " <= " << last_captured_timestamp_
                     << ") for incoming frame. Dropping.";
     return;
   }
 
-  captured_frame_.ShallowCopy(incoming_frame);
+  captured_frame_.reset(new VideoFrame);

[pbos-webrtc, 2016/04/13 12:31:52]

Consider getting rid of this heap allocation.

[nisse-webrtc, 2016/04/13 12:45:26]

It's kind-of tricky. 

1. I aim to make sure that a VideoFrame always has a valid pointer to an
underlying VideoFrameBuffer. 

2. The GetVideoFrame method here wants to drop that reference.

The only straightforward way to get both is to destroy the VideoFrame object.

A better way might be to change GetVideoFrame return a unique_ptr<VideoFrame>?
Then we can also eliminate the (shallow) copy. 

+  captured_frame_->ShallowCopy(incoming_frame);
   last_captured_timestamp_ = incoming_frame.ntp_time_ms();
 
-  overuse_detector_->FrameCaptured(captured_frame_);
+  overuse_detector_->FrameCaptured(*captured_frame_);
 
   TRACE_EVENT_ASYNC_BEGIN1("webrtc", "Video", video_frame.render_time_ms(),
                            "render_time", video_frame.render_time_ms());
 
   capture_event_->Set();
 }
 
 bool VideoCaptureInput::GetVideoFrame(VideoFrame* video_frame) {
   rtc::CritScope lock(&crit_);
-  if (captured_frame_.IsZeroSize())
+  if (!captured_frame_)
     return false;
 
-  *video_frame = captured_frame_;
-  captured_frame_.Reset();
+  *video_frame = *captured_frame_;
+  captured_frame_.reset();
   return true;
 }
 
 }  // namespace internal
 }  // namespace webrtc