Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 1888903003: Network thread (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman, juberti1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Network thread A new Thread added that take network part of the Worker thread. In particluar it stamp current time on incoming packets. Beeing slim, this thread make the timestamps more accurate than worker thread. Accurate packet timestamps are very important for bitrate prober. Few milliseconds of delay confuse prober too much. COMMIT=false BUG=webrtc:5645

Patch Set 1 #

Patch Set 2 : rollback unrelated changes, moved SRTP to network thread #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+919 lines, -636 lines) Patch
M webrtc/api/fakemediacontroller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 2 3 7 chunks +39 lines, -17 lines 0 comments Download
M webrtc/api/mediacontroller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/mediacontroller.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/api/peerconnection.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 2 3 9 chunks +28 lines, -17 lines 0 comments Download
M webrtc/api/peerconnectionendtoend_unittest.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectionfactory.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 1 2 3 6 chunks +33 lines, -27 lines 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/api/statscollector_unittest.cc View 1 2 3 15 chunks +30 lines, -15 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 1 2 3 2 chunks +10 lines, -6 lines 0 comments Download
M webrtc/api/webrtcsession.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/webrtcsession.cc View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 2 3 3 chunks +13 lines, -13 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 1 2 3 4 chunks +33 lines, -33 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 1 2 3 24 chunks +119 lines, -118 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/channel.h View 1 2 3 16 chunks +41 lines, -32 lines 0 comments Download
M webrtc/pc/channel.cc View 1 2 3 51 chunks +262 lines, -152 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 1 2 3 20 chunks +228 lines, -127 lines 0 comments Download
M webrtc/pc/channelmanager.h View 1 4 chunks +13 lines, -4 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 1 6 chunks +27 lines, -34 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
juberti2
4 years, 7 months ago (2016-05-12 03:15:11 UTC) #1
Description was changed from

==========
Network thread

A new Thread added that take network part of the Worker thread.
In particluar it stamp current time on incoming packets.
Beeing slim, this thread make the timestamps more accurate than worker thread.
Accurate packet timestamps are very important for bitrate prober.
Few milliseconds of delay confuse prober too much.

COMMIT=false
BUG=webrtc:5645
==========

to

==========
Network thread

A new Thread added that take network part of the Worker thread.
In particluar it stamp current time on incoming packets.
Beeing slim, this thread make the timestamps more accurate than worker thread.
Accurate packet timestamps are very important for bitrate prober.
Few milliseconds of delay confuse prober too much.

COMMIT=false
BUG=webrtc:5645
==========

Powered by Google App Engine
This is Rietveld 408576698