Use bitstream-level QP for libvpx VP8 quality.

Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
TBR=marpan@webrtc.org

Committed: https://crrev.com/8056acc6f5c4b4d005ca3c77fb6d6f109632cebc
Cr-Commit-Position: refs/heads/master@{#12401}

[pbos-webrtc, 2016-04-14 16:15:07]

PTAL, need help with mapping 0-63 to 0-127 (since they're not /=2).

https://codereview.webrtc.org/1888843002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/1888843002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:603: const int
kLowQpThreshold = 36;  // BEFORE SUBMITTING: What value is 18 in HW?           
Needs fixing!
What should go here to replace 18 with bitstream-level 18?

[marpan, 2016-04-14 19:24:00]

marpan@google.com changed reviewers:
+ marpan@google.com

[marpan, 2016-04-14 19:24:00]

https://codereview.webrtc.org/1888843002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/1888843002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:603: const int
kLowQpThreshold = 36;  // BEFORE SUBMITTING: What value is 18 in HW?           
Needs fixing!
On 2016/04/14 16:15:07, pbos-webrtc wrote:
> What should go here to replace 18 with bitstream-level 18?
The map (from user-level to bitstream value) is given by q_trans[], found in
vp8/encoder/onyx_if.c, at line ~1332.

[pbos-webrtc, 2016-04-15 09:04:44]

use correct bitstream-level QP

[pbos-webrtc, 2016-04-15 09:06:58]

PTAL, If I read this correctly QP=18 corresponds to 23 in the bitstream.

[stefan-webrtc, 2016-04-15 09:21:08]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-04-15 09:21:09]

https://codereview.webrtc.org/1888843002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/1888843002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:603: const int
kLowQpThreshold = 23;
Please clarify in the code why this was chosen to be 23.

[pbos-webrtc, 2016-04-15 09:45:00]

add comment

[pbos-webrtc, 2016-04-15 09:45:03]

PTAL, added a comment

[pbos-webrtc, 2016-04-18 09:14:03]

Description was changed from

==========
Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
R=marpan@webrtc.org
==========

to

==========
Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
TBR=marpan@webrtc.org
==========

[pbos-webrtc, 2016-04-18 09:15:10]

Putting TBR so I can put up pending CLs for review (and this is the threshold
you told me)

[commit-bot: I haz the power, 2016-04-18 09:17:48]

Description was changed from

==========
Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
TBR=marpan@webrtc.org
==========

to

==========
Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
TBR=marpan@webrtc.org

Committed: https://crrev.com/8056acc6f5c4b4d005ca3c77fb6d6f109632cebc
Cr-Commit-Position: refs/heads/master@{#12401}
==========

[pbos-webrtc, 2016-04-18 09:17:48]

Description was changed from

==========
Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
TBR=marpan@webrtc.org

Committed: https://crrev.com/8056acc6f5c4b4d005ca3c77fb6d6f109632cebc
Cr-Commit-Position: refs/heads/master@{#12401}
==========

to

==========
Use bitstream-level QP for libvpx VP8 quality.

BUG=webrtc:5678
TBR=marpan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8056acc6f5c4b4d005ca3c77f...
==========

[commit-bot: I haz the power, 2016-04-18 09:17:49]

Patchset 3 (id:??) landed as
https://crrev.com/8056acc6f5c4b4d005ca3c77fb6d6f109632cebc
Cr-Commit-Position: refs/heads/master@{#12401}

[pbos-webrtc, 2016-04-18 09:17:50]

Committed patchset #3 (id:40001) manually as
8056acc6f5c4b4d005ca3c77fb6d6f109632cebc (presubmit successful).