Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

BUG=chromium:603483
R=asapersson@webrtc.org

Committed: https://crrev.com/ee6e4272a4cb28ee6cf38bc73585b82f316b0682
Cr-Commit-Position: refs/heads/master@{#12423}

[danilchap, 2016-04-15 12:41:24]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[åsapersson, 2016-04-18 09:51:47]

https://codereview.webrtc.org/1888793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_utility.cc (right):

https://codereview.webrtc.org/1888793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1455: _packet.REMBItem.BitRate =
(brMantissa << brExp);
Might give an incorrect bitrate if brExp > 14, right?

[danilchap, 2016-04-18 10:41:42]

https://codereview.webrtc.org/1888793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_utility.cc (right):

https://codereview.webrtc.org/1888793003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1455: _packet.REMBItem.BitRate =
(brMantissa << brExp);
On 2016/04/18 09:51:47, åsapersson wrote:
> Might give an incorrect bitrate if brExp > 14, right?

Yes, it can. Updated code to be stricter about unsupported (too large) bitrate.

[åsapersson, 2016-04-18 13:34:15]

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_utility.cc (right):

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1458: LOG(LS_ERROR) << "Invalid
remb bitrate value : " << mantissa
maybe invalid -> unhandled (here and below)

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1465: 
Add test (rtcp_receiver_test.cc) which inserts a REMB packet?

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1523: LOG(LS_ERROR) << "Invalid
remb bitrate value : " << mantissa
remb -> tmmbr

[danilchap, 2016-04-18 19:06:14]

Description was changed from

==========
Fixed undefinedi shift in parsing Tmmbr, Tmmbn and Remb

BUG=603483
==========

to

==========
Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

BUG=chromium:603483
==========

[danilchap, 2016-04-18 19:08:15]

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_utility.cc (right):

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1458: LOG(LS_ERROR) << "Invalid
remb bitrate value : " << mantissa
On 2016/04/18 13:34:15, åsapersson wrote:
> maybe invalid -> unhandled (here and below)

Done.

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1465: 
On 2016/04/18 13:34:15, åsapersson wrote:
> Add test (rtcp_receiver_test.cc) which inserts a REMB packet?

There was a hidden test (HandlesInvalidTransportFeedback), added an explicit
test for remb.

https://codereview.webrtc.org/1888793003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_utility.cc:1523: LOG(LS_ERROR) << "Invalid
remb bitrate value : " << mantissa
On 2016/04/18 13:34:15, åsapersson wrote:
> remb -> tmmbr

Oops, done.

[åsapersson, 2016-04-19 10:06:59]

lgtm

https://codereview.webrtc.org/1888793003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc (right):

https://codereview.webrtc.org/1888793003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc:1256:
remb.From(kSourceSsrc);
kSenderSsrc

[danilchap, 2016-04-19 10:15:26]

Description was changed from

==========
Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

BUG=chromium:603483
==========

to

==========
Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

BUG=chromium:603483
R=asapersson@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ee6e4272a4cb28ee6cf38bc73...
==========

[commit-bot: I haz the power, 2016-04-19 10:15:27]

Description was changed from

==========
Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

BUG=chromium:603483
R=asapersson@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ee6e4272a4cb28ee6cf38bc73...
==========

to

==========
Fixed undefined shift in parsing Tmmbr, Tmmbn and Remb

BUG=chromium:603483
R=asapersson@webrtc.org

Committed: https://crrev.com/ee6e4272a4cb28ee6cf38bc73585b82f316b0682
Cr-Commit-Position: refs/heads/master@{#12423}
==========

[danilchap, 2016-04-19 10:15:27]

Committed patchset #5 (id:80001) manually as
ee6e4272a4cb28ee6cf38bc73585b82f316b0682 (presubmit successful).

[commit-bot: I haz the power, 2016-04-19 10:15:28]

Patchset 5 (id:??) landed as
https://crrev.com/ee6e4272a4cb28ee6cf38bc73585b82f316b0682
Cr-Commit-Position: refs/heads/master@{#12423}