Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h

Issue 1888633002: Added the API to create an RTCRtpSender to the Objective C wrapper. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased to the new directory structure Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h
index c874b77e6bb0a508186ae94cb7c00cce1e285f2c..f5eb07a7bfdef86d9eacf56b710f0f9f74c1079c 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpSender.h
@@ -19,22 +19,20 @@ NS_ASSUME_NONNULL_BEGIN
RTC_EXPORT
@protocol RTCRtpSender <NSObject>
+/** A unique identifier for this sender. */
+@property(nonatomic, readonly) NSString *senderId;
+
/** The currently active RTCRtpParameters, as defined in
* https://www.w3.org/TR/webrtc/#idl-def-RTCRtpParameters.
*/
-@property(nonatomic, readonly) RTCRtpParameters *parameters;
+@property(nonatomic) RTCRtpParameters *parameters;
tkchin_webrtc 2016/04/27 20:22:20 nit: nonatomic, copy?
skvlad 2016/04/27 23:00:58 Good catch, copy is the right thing here.
/** The RTCMediaStreamTrack associated with the sender.
* Note: reading this property returns a new instance of
* RTCMediaStreamTrack. Use isEqual: instead of == to compare
* RTCMediaStreamTrack instances.
*/
-@property(nonatomic, readonly) RTCMediaStreamTrack *track;
-
-/** Set the new RTCRtpParameters to be used by the sender.
- * Returns YES if the new parameters were applied, NO otherwise.
- */
-- (BOOL)setParameters:(RTCRtpParameters *)parameters;
+@property(nonatomic) RTCMediaStreamTrack *track;
tkchin_webrtc 2016/04/27 20:22:20 I'm surprised this wasn't throwing a warning - thi
skvlad 2016/04/27 23:00:58 Is "copy" the right annotation for the behavior we
tkchin_webrtc 2016/04/27 23:13:43 Sort-of. Since we are overriding the setter these
@end

Powered by Google App Engine
This is Rietveld 408576698