Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1888453004: Remove VERBOSE logs from frame_dropper.cc. (Closed)

Created:
4 years, 8 months ago by noahric
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VERBOSE logs from frame_dropper.cc. They are way too verbose, ~100 lines of log per second. BUG= Committed: https://crrev.com/91efeecab834684e898828340a8738adb680dccc Cr-Commit-Position: refs/heads/master@{#12356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M webrtc/modules/video_coding/utility/frame_dropper.cc View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
noahric
Hey guys, I'm guessing these logs can be useful for some debugging, but they drown ...
4 years, 8 months ago (2016-04-13 22:27:31 UTC) #2
pbos-webrtc
+stefan@ just in case they'd be useful for something, but I really think not, lgtm ...
4 years, 8 months ago (2016-04-13 22:32:36 UTC) #4
Irfan
lgtm This was very useful when I was fixing the frame dropper. But, its probably ...
4 years, 8 months ago (2016-04-13 23:04:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888453004/1
4 years, 8 months ago (2016-04-14 03:28:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 04:01:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 04:01:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91efeecab834684e898828340a8738adb680dccc
Cr-Commit-Position: refs/heads/master@{#12356}

Powered by Google App Engine
This is Rietveld 408576698