webrtc/api/webrtcsdp_unittest.cc - Issue 1888373002: Don't write spaces after semicolons in FMTP lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsdp_unittest.cc

Issue 1888373002: Don't write spaces after semicolons in FMTP lines. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Removed a space in an objc test expectation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsdp_unittest.cc

diff --git a/webrtc/api/webrtcsdp_unittest.cc b/webrtc/api/webrtcsdp_unittest.cc

index 2b63c798b07755aa1bb963b945984c9edc1f81d2..f222b3fc9a5932f277b01e80f49d05e3a35e85ec 100644

--- a/webrtc/api/webrtcsdp_unittest.cc

+++ b/webrtc/api/webrtcsdp_unittest.cc

@@ -2114,6 +2114,9 @@ TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithH264) {

EXPECT_NE(std::string::npos, fmtp_value.find("level-asymmetry-allowed=1"));

EXPECT_NE(std::string::npos, fmtp_value.find("packetization-mode=1"));

EXPECT_NE(std::string::npos, fmtp_value.find("profile-level-id=42e01f"));

+ // Check that there are no spaces after semicolons.

+ // https://bugs.webrtc.org/5793

+ EXPECT_EQ(std::string::npos, fmtp_value.find("; "));

}

TEST_F(WebRtcSdpTest, DeserializeSessionDescription) {

« no previous file with comments | « webrtc/api/webrtcsdp.cc ('k') | no next file » | no next file with comments »