Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: webrtc/api/webrtcsdp.cc

Issue 1888373002: Don't write spaces after semicolons in FMTP lines. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed a space in an objc test expectation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objctests/RTCSessionDescriptionTest.mm ('k') | webrtc/api/webrtcsdp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/webrtcsdp.cc
diff --git a/webrtc/api/webrtcsdp.cc b/webrtc/api/webrtcsdp.cc
index 8497f4c5fa9bbc5f79e16b85d26079963e55cd89..10f99224f82d8a045e5fb1a76cce52792021b60f 100644
--- a/webrtc/api/webrtcsdp.cc
+++ b/webrtc/api/webrtcsdp.cc
@@ -1564,11 +1564,13 @@ void WriteFmtpParameters(const cricket::CodecParameterMap& parameters,
std::ostringstream* os) {
for (cricket::CodecParameterMap::const_iterator fmtp = parameters.begin();
fmtp != parameters.end(); ++fmtp) {
- // Each new parameter, except the first one starts with ";" and " ".
- if (fmtp != parameters.begin()) {
+ // Parameters are a semicolon-separated list, no spaces.
+ // The list is separated from the header by a space.
+ if (fmtp == parameters.begin()) {
+ *os << kSdpDelimiterSpace;
+ } else {
*os << kSdpDelimiterSemicolon;
}
- *os << kSdpDelimiterSpace;
WriteFmtpParameter(fmtp->first, fmtp->second, os);
}
}
« no previous file with comments | « webrtc/api/objctests/RTCSessionDescriptionTest.mm ('k') | webrtc/api/webrtcsdp_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698