webrtc/modules/video_coding/utility/vp8_header_parser.h - Issue 1888313002: Fix the issue of undefined-shift in VP8GetBit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/utility/vp8_header_parser.h

Issue 1888313002: Fix the issue of undefined-shift in VP8GetBit. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Use error_ to save bitReader status. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/utility/vp8_header_parser.h

diff --git a/webrtc/modules/video_coding/utility/vp8_header_parser.h b/webrtc/modules/video_coding/utility/vp8_header_parser.h

index b0c684c578b1e0628f62574050468b6415807f34..d4c30eac166107868680c765e6461a05e21832ad 100644

--- a/webrtc/modules/video_coding/utility/vp8_header_parser.h

+++ b/webrtc/modules/video_coding/utility/vp8_header_parser.h

@@ -35,6 +35,7 @@ struct VP8BitReader {

const uint8_t* buf_; // Next byte to be read.

const uint8_t* buf_end_; // End of read buffer.

int eof_; // True if input is exhausted.

+ bool error_; // True if input stream contains an error.

};

const uint8_t kVP8Log2Range[128] = {