Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1887493003: Reland of Make QualityScaler more responsive to downgrades. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make QualityScaler more responsive to downgrades. (patchset #1 id:1 of https://codereview.webrtc.org/1880103002/ ) Reason for revert: Regressed behavior is actually desirable (go down to 360p instead of producing super-bad 720p). Original issue's description: > Revert of Make QualityScaler more responsive to downgrades. (patchset #3 id:40001 of https://codereview.webrtc.org/1830593003/ ) > > Reason for revert: > Speculative revert: want to see if this causes the regression in https://crbug.com/602621 > > Original issue's description: > > Make QualityScaler more responsive to downgrades. > > > > Permits going from HD to QVGA in 6 seconds instead of 10. Also adds > > windows for going up quickly in the beginning of a call (before any > > downscaling happens due to bad quality). > > > > BUG=webrtc:5678 > > R=glaznev@webrtc.org, stefan@webrtc.org > > > > Committed: https://crrev.com/85829fd90cc4e7a91c9857921b19e8fc126aeb60 > > Cr-Commit-Position: refs/heads/master@{#12219} > > TBR=glaznev@webrtc.org,stefan@webrtc.org,pbos@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5678 > NOTRY=true > > Committed: https://crrev.com/19b4fecf08e3fe215e431a260fb673553c15e569 > Cr-Commit-Position: refs/heads/master@{#12331} TBR=glaznev@webrtc.org,stefan@webrtc.org,phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:602621, webrtc:5678 Committed: https://crrev.com/cbac40d3213ed7be1be49c139e9ffd4d9fec284c Cr-Commit-Position: refs/heads/master@{#12341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -45 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.h View 2 chunks +9 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 9 chunks +35 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 6 chunks +96 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pbos-webrtc
Created Reland of Make QualityScaler more responsive to downgrades.
4 years, 8 months ago (2016-04-13 09:50:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887493003/1
4 years, 8 months ago (2016-04-13 09:50:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 09:51:06 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 09:51:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbac40d3213ed7be1be49c139e9ffd4d9fec284c
Cr-Commit-Position: refs/heads/master@{#12341}

Powered by Google App Engine
This is Rietveld 408576698