Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1886533002: Fix paths to Android tests .isolate files. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix paths to Android tests .isolate files. These errors surfaced after https://codereview.chromium.org/1882103002/ was committed recently. The tests previously used a path passed on command line by the recipe. TBR=agrieve@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/1a45cfbe8bf19146d76ae142ee14a8d83f59427c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/build/apk_tests.gyp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
4 years, 8 months ago (2016-04-12 20:14:49 UTC) #1
kjellander_webrtc
Committed patchset #1 (id:1) manually as 1a45cfbe8bf19146d76ae142ee14a8d83f59427c (presubmit successful).
4 years, 8 months ago (2016-04-12 20:15:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a45cfbe8bf19146d76ae142ee14a8d83f59427c Cr-Commit-Position: refs/heads/master@{#12335}
4 years, 8 months ago (2016-04-12 20:15:26 UTC) #5
agrieve
4 years, 8 months ago (2016-04-12 20:39:11 UTC) #6
Message was sent while issue was closed.
On 2016/04/12 20:15:26, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/1a45cfbe8bf19146d76ae142ee14a8d83f59427c
> Cr-Commit-Position: refs/heads/master@{#12335}

sorry! lgtm!

Powered by Google App Engine
This is Rietveld 408576698