Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1886383002: Make ReliableQuicStream::Write use base::StringPiece, not std::string (Closed)

Created:
4 years, 8 months ago by mikescarlett
Modified:
4 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make ReliableQuicStream::Write use base::StringPiece, not std::string Minor change; necesary to eliminate an O(N) performance penalty every time ReliableQuicStream::Write is called. TBR=pthatcher@webrtc.org BUG= Committed: https://crrev.com/47e381b8c11ee641d8c98235d029518271d17c92 Cr-Commit-Position: refs/heads/master@{#12367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/p2p/quic/reliablequicstream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886383002/1
4 years, 8 months ago (2016-04-14 17:14:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 18:12:50 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 18:12:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47e381b8c11ee641d8c98235d029518271d17c92
Cr-Commit-Position: refs/heads/master@{#12367}

Powered by Google App Engine
This is Rietveld 408576698