webrtc/modules/audio_processing/echo_cancellation_impl.cc - Issue 1886233003: Added a protobuf field for the audio processing module to store the status of experiments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.cc

Issue 1886233003: Added a protobuf field for the audio processing module to store the status of experiments (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added unittest for reading of the added protobuf field Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/echo_cancellation_impl.h ('k') | webrtc/modules/audio_processing/test/debug_dump_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/echo_cancellation_impl.cc

diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.cc b/webrtc/modules/audio_processing/echo_cancellation_impl.cc

index 810ea8965542a146de325fc144376c98993dd6a0..12ea75efe1b65ff9f3da7bda63d027426c449830 100644

--- a/webrtc/modules/audio_processing/echo_cancellation_impl.cc

+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.cc

@@ -413,6 +413,11 @@ bool EchoCancellationImpl::is_aec3_enabled() const {

return aec3_enabled_;

}

+std::string EchoCancellationImpl::GetExperimentsDescription() {

+ rtc::CritScope cs(crit_capture_);

+ return aec3_enabled_ ? "AEC3" : "";

bool EchoCancellationImpl::is_extended_filter_enabled() const {

rtc::CritScope cs(crit_capture_);

return extended_filter_enabled_;