Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Side by Side Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1886233003: Added a protobuf field for the audio processing module to store the status of experiments (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1421 matching lines...) Expand 10 before | Expand all | Expand 10 after
1432 1432
1433 config.set_hpf_enabled(public_submodules_->high_pass_filter->is_enabled()); 1433 config.set_hpf_enabled(public_submodules_->high_pass_filter->is_enabled());
1434 1434
1435 config.set_ns_enabled(public_submodules_->noise_suppression->is_enabled()); 1435 config.set_ns_enabled(public_submodules_->noise_suppression->is_enabled());
1436 config.set_ns_level( 1436 config.set_ns_level(
1437 static_cast<int>(public_submodules_->noise_suppression->level())); 1437 static_cast<int>(public_submodules_->noise_suppression->level()));
1438 1438
1439 config.set_transient_suppression_enabled( 1439 config.set_transient_suppression_enabled(
1440 capture_.transient_suppressor_enabled); 1440 capture_.transient_suppressor_enabled);
1441 1441
1442 std::string experiments_description = "";
1443 experiments_description +=
hlundin-webrtc 2016/04/14 07:50:07 You don't have to define the string empty first, a
peah-webrtc 2016/04/14 11:11:06 Done.
1444 public_submodules_->echo_cancellation->GetExperimentsDescription();
1445 // TODO(peah): Add semicolon separated concatenations of experiment
hlundin-webrtc 2016/04/14 07:50:07 Language nit: "semicolon-separated" (with a hyphen
peah-webrtc 2016/04/14 11:11:06 Done.
1446 // descriptions for other submodules.
1447 config.set_experiments_description(experiments_description);
1448
1442 std::string serialized_config = config.SerializeAsString(); 1449 std::string serialized_config = config.SerializeAsString();
1443 if (!forced && 1450 if (!forced &&
1444 debug_dump_.capture.last_serialized_config == serialized_config) { 1451 debug_dump_.capture.last_serialized_config == serialized_config) {
1445 return kNoError; 1452 return kNoError;
1446 } 1453 }
1447 1454
1448 debug_dump_.capture.last_serialized_config = serialized_config; 1455 debug_dump_.capture.last_serialized_config = serialized_config;
1449 1456
1450 debug_dump_.capture.event_msg->set_type(audioproc::Event::CONFIG); 1457 debug_dump_.capture.event_msg->set_type(audioproc::Event::CONFIG);
1451 debug_dump_.capture.event_msg->mutable_config()->CopyFrom(config); 1458 debug_dump_.capture.event_msg->mutable_config()->CopyFrom(config);
1452 1459
1453 RETURN_ON_ERR(WriteMessageToDebugFile(debug_dump_.debug_file.get(), 1460 RETURN_ON_ERR(WriteMessageToDebugFile(debug_dump_.debug_file.get(),
1454 &debug_dump_.num_bytes_left_for_log_, 1461 &debug_dump_.num_bytes_left_for_log_,
1455 &crit_debug_, &debug_dump_.capture)); 1462 &crit_debug_, &debug_dump_.capture));
1456 return kNoError; 1463 return kNoError;
1457 } 1464 }
1458 #endif // WEBRTC_AUDIOPROC_DEBUG_DUMP 1465 #endif // WEBRTC_AUDIOPROC_DEBUG_DUMP
1459 1466
1460 } // namespace webrtc 1467 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_processing/debug.proto » ('j') | webrtc/modules/audio_processing/debug.proto » ('J')

Powered by Google App Engine
This is Rietveld 408576698