webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h - Issue 1886113003: Add rotation to EncodedImage and make sure it is passed through encoders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

Issue 1886113003: Add rotation to EncodedImage and make sure it is passed through encoders. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix merge mistake. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc ('k') | webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

index 779889d43ccdd32b177bbd86ce12e1ab7fa7401a..78b76536c9a8da6efe118bd60e221ff78fcf0b13 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

+++ b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

@@ -12,6 +12,7 @@

#ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_

#define WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_

+#include "webrtc/common_video/rotation.h"

#include "webrtc/modules/video_coding/codecs/h264/include/h264.h"

#include "webrtc/modules/video_coding/include/bitrate_adjuster.h"

@@ -58,7 +59,8 @@ class H264VideoToolboxEncoder : public H264Encoder {

int32_t width,

int32_t height,

int64_t render_time_ms,

- uint32_t timestamp);

+ uint32_t timestamp,

+ VideoRotation rotation);

private:

int ResetCompressionSession();