Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1885943004: Revert of Introduce an IsMutable method on VideoFrameBuffer. (Closed)

Created:
4 years, 8 months ago by guidou
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Introduce an IsMutable method on VideoFrameBuffer. (patchset #1 id:1 of https://codereview.webrtc.org/1881933004/ ) Reason for revert: This is breaking all FYI bots. The new virtual method is not implemented on the Chromium side yet. Original issue's description: > Introduce an IsMutable method on VideoFrameBuffer. > > Unlike HasOneRef, it can be overridden to always return false in > immutable subclasses. > > I'm also investigating overiding it in PooledI420Buffer, to directly > inherit I420Buffer but ignore the reference from the pool. Still > unclear if that will work out. > > BUG=webrtc:5682 > > Committed: https://crrev.com/6bd10f2c1ac912cbe5addd880e559d59274c60e6 > Cr-Commit-Position: refs/heads/master@{#12365} TBR=magjed@webrtc.org,perkj@webrtc.org,pbos@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/dad23d06aa1c679fc2dbbabeab64f293e886b8e3 Cr-Commit-Position: refs/heads/master@{#12366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -32 lines) Patch
M webrtc/common_video/i420_buffer_pool.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/common_video/i420_buffer_pool_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 4 chunks +1 line, -11 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/video_frame_buffer.cc View 3 chunks +1 line, -14 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
guidou
Created Revert of Introduce an IsMutable method on VideoFrameBuffer.
4 years, 8 months ago (2016-04-14 16:34:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885943004/1
4 years, 8 months ago (2016-04-14 16:34:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 16:35:00 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 16:35:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dad23d06aa1c679fc2dbbabeab64f293e886b8e3
Cr-Commit-Position: refs/heads/master@{#12366}

Powered by Google App Engine
This is Rietveld 408576698