Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1885893002: Remove QualityScaler framerate reduction. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
jackychen, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove QualityScaler framerate reduction. Framerate-reduction code is disabled on all platforms, and this code adds complexity. It's necessary to react fast, especially on mobile platforms or other bad network conditions and framerate reduction adds another step between HD and QVGA. BUG=webrtc:5678, webrtc:5830 R=jackychen@webrtc.org, mflodman@webrtc.org Committed: https://crrev.com/3c6eac2860ffea44c193b3e34a6711e8142f8379 Cr-Commit-Position: refs/heads/master@{#12503}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -228 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 4 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 5 chunks +3 lines, -31 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 1 8 chunks +8 lines, -130 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/video_processing/include/video_processing.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_processing_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/video_processing_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/video/video_encoder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/video_encoder.h View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
pbos-webrtc
PTAL, this hasn't been active for a while and works against the goal of reacting ...
4 years, 8 months ago (2016-04-13 14:58:23 UTC) #1
jackychen
Agree with this change based on my own observation. LGTM.
4 years, 8 months ago (2016-04-13 17:10:52 UTC) #2
pbos-webrtc
rebase
4 years, 8 months ago (2016-04-24 19:05:54 UTC) #3
pbos-webrtc
mflodman@: Could you take a look soon, this is rebase-heavy since thresholds etc. in QualityScaler ...
4 years, 8 months ago (2016-04-24 19:06:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885893002/20001
4 years, 8 months ago (2016-04-24 21:39:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-24 22:41:58 UTC) #8
mflodman
Code LG, I just have a question around frame dropping in general that I think ...
4 years, 8 months ago (2016-04-26 06:43:15 UTC) #9
mflodman
On 2016/04/26 06:43:15, mflodman wrote: > Code LG, I just have a question around frame ...
4 years, 8 months ago (2016-04-26 06:43:38 UTC) #10
mflodman
LGTM, please file a bug as discussed.
4 years, 8 months ago (2016-04-26 09:51:13 UTC) #11
pbos-webrtc
On 2016/04/26 09:51:13, mflodman wrote: > LGTM, please file a bug as discussed. Done!
4 years, 8 months ago (2016-04-26 11:29:49 UTC) #13
pbos-webrtc
Committed patchset #2 (id:20001) manually as 3c6eac2860ffea44c193b3e34a6711e8142f8379 (presubmit successful).
4 years, 8 months ago (2016-04-26 11:37:27 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 11:37:31 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c6eac2860ffea44c193b3e34a6711e8142f8379
Cr-Commit-Position: refs/heads/master@{#12503}

Powered by Google App Engine
This is Rietveld 408576698