Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: webrtc/api/objc/RTCRtpCodecParameters.h

Issue 1885473004: Adding codecs to the RtpParameters returned by an RtpSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Responding to skvlad@ feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCRtpCodecParameters.h
diff --git a/webrtc/api/objc/RTCRtpEncodingParameters.h b/webrtc/api/objc/RTCRtpCodecParameters.h
similarity index 52%
copy from webrtc/api/objc/RTCRtpEncodingParameters.h
copy to webrtc/api/objc/RTCRtpCodecParameters.h
index 8f7f22e04df1d35857dc46b2631805555c4189f5..73e0819aef06d0341282cd33d5b2959b66f62432 100644
--- a/webrtc/api/objc/RTCRtpEncodingParameters.h
+++ b/webrtc/api/objc/RTCRtpCodecParameters.h
@@ -12,15 +12,22 @@
NS_ASSUME_NONNULL_BEGIN
-@interface RTCRtpEncodingParameters : NSObject
+@interface RTCRtpCodecParameters : NSObject
-/** Controls whether the encoding is currently transmitted. */
-@property(nonatomic, assign) BOOL isActive;
+/** The RTP payload type. */
+@property(nonatomic, assign) int payloadType;
-/** The maximum bitrate to use for the encoding, or nil if there is no
- * limit.
+/**
+ * The codec MIME type. Valid types are listed in:
+ * http://www.iana.org/assignments/rtp-parameters/rtp-parameters.xhtml#rtp-parameters-2
*/
-@property(nonatomic, copy, nullable) NSNumber *maxBitrateBps;
+@property(nonatomic, nonnull) NSString *mimeType;
+
+/** The codec clock rate expressed in Hertz. */
+@property(nonatomic, assign) int clockRate;
+
+/** The number of channels (mono=1, stereo=2). */
pthatcher1 2016/04/14 15:58:12 Why not include these comments in the .java file a
Taylor Brandstetter 2016/04/14 16:30:54 I was just following the convention. The C++ .h fi
+@property(nonatomic, assign) int channels;
- (instancetype)init NS_DESIGNATED_INITIALIZER;

Powered by Google App Engine
This is Rietveld 408576698