webrtc/media/engine/webrtcvideoengine2.h - Issue 1885473004: Adding codecs to the RtpParameters returned by an RtpSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1885473004: Adding codecs to the RtpParameters returned by an RtpSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Responding to review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvideoengine2.h

diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h

index b9ab0b71ed6f41dcd277c1e83dfcd211cc3c1b28..36c70d0e56082b9d04f6de7618b755a24e15b130 100644

--- a/webrtc/media/engine/webrtcvideoengine2.h

+++ b/webrtc/media/engine/webrtcvideoengine2.h

@@ -380,6 +380,7 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {

// entire channel.

VideoSendStreamParameters parameters_ GUARDED_BY(lock_);

// Contains settings that are unique for each stream, such as max_bitrate.

+ // Does *not* contain codecs, however.

// TODO(skvlad): Move ssrcs_ and ssrc_groups_ into rtp_parameters_.

// TODO(skvlad): Combine parameters_ and rtp_parameters_ once we have only

// one stream per MediaChannel.

« webrtc/api/java/jni/peerconnection_jni.cc ('K') | « webrtc/media/base/codec.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »