Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1885443002: Rename some cricket::VideoFrame methods, to align with webrtc::VideoFrame. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename some cricket::VideoFrame methods, to align with webrtc::VideoFrame. GetVideoFrameBuffer --> video_frame_buffer GetVideoRotation --> rotation SetRotation --> set_rotation BUG=webrtc:5682 Committed: https://crrev.com/f38687635426bb9b5c53d81367a1618f9555c3ef Cr-Commit-Position: refs/heads/master@{#12342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M webrtc/api/java/jni/peerconnection_jni.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/objc/RTCVideoFrame.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videobroadcaster.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/base/videoframe.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/base/videoframe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nisse-webrtc
Affected methods appear unused in Chrome.
4 years, 8 months ago (2016-04-12 07:22:00 UTC) #2
perkj_webrtc
On 2016/04/12 07:22:00, nisse-webrtc wrote: > Affected methods appear unused in Chrome. lgtm
4 years, 8 months ago (2016-04-12 10:57:42 UTC) #3
magjed_webrtc
lgtm
4 years, 8 months ago (2016-04-13 08:32:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885443002/1
4 years, 8 months ago (2016-04-13 08:37:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 10:29:21 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 10:29:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f38687635426bb9b5c53d81367a1618f9555c3ef
Cr-Commit-Position: refs/heads/master@{#12342}

Powered by Google App Engine
This is Rietveld 408576698