Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1885323002: Delete unused methods SetStartImage and SetTimeoutImage. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, perkj_webrtc, mflodman, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused methods SetStartImage and SetTimeoutImage. Declared in webrtc::VideoRender, implemented in IncomingVideoStream. This cl also eliminates some of the few uses of webrtc::VideoFrame::CopyFrame. BUG=webrtc:5682 Committed: https://crrev.com/cc23b7c1ea33a252736986e2d3089215f78a6794 Cr-Commit-Position: refs/heads/master@{#12427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -169 lines) Patch
M webrtc/common_video/include/incoming_video_stream.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 4 chunks +1 line, -35 lines 0 comments Download
M webrtc/modules/video_render/video_render.h View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/video_render/video_render_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/video_render/video_render_impl.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M webrtc/modules/video_render/video_render_internal_impl.cc View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
nisse-webrtc
4 years, 8 months ago (2016-04-14 11:04:52 UTC) #2
perkj_webrtc
On 2016/04/14 11:04:52, nisse-webrtc wrote: lgtm - but please ask the "owner" for approval.
4 years, 8 months ago (2016-04-14 11:27:16 UTC) #3
nisse-webrtc
These appear unused. Ok to delete?
4 years, 8 months ago (2016-04-14 11:28:30 UTC) #5
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-19 09:21:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885323002/1
4 years, 8 months ago (2016-04-19 09:27:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-19 11:28:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885323002/1
4 years, 8 months ago (2016-04-19 12:02:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 13:19:43 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 13:19:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc23b7c1ea33a252736986e2d3089215f78a6794
Cr-Commit-Position: refs/heads/master@{#12427}

Powered by Google App Engine
This is Rietveld 408576698