Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1884863004: Revert of Use microsecond timestamp in cricket::VideoFrame. (Closed)

Created:
4 years, 8 months ago by niklas.enbom
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use microsecond timestamp in cricket::VideoFrame. (patchset #13 id:240001 of https://codereview.webrtc.org/1865283002/ ) Reason for revert: This CL breaks Chrome FYI bots compile: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/4942/steps/compile/logs/stdio Original issue's description: > Use microsecond timestamp in cricket::VideoFrame. > > BUG=webrtc:5740 > > Committed: https://crrev.com/f30ba114bb33dd1d8643bc640dda2e0c86dbbd32 > Cr-Commit-Position: refs/heads/master@{#12348} TBR=perkj@webrtc.org,pbos@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5740 Committed: https://crrev.com/09eabcb4fbf78aa8eb817c2b566b8984a199f965 Cr-Commit-Position: refs/heads/master@{#12350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -115 lines) Patch
M webrtc/media/base/fakevideocapturer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/base/videobroadcaster.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/media/base/videoframe.h View 2 chunks +4 lines, -16 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 5 chunks +14 lines, -25 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 8 chunks +22 lines, -31 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
niklas.enbom
Created Revert of Use microsecond timestamp in cricket::VideoFrame.
4 years, 8 months ago (2016-04-13 17:45:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884863004/1
4 years, 8 months ago (2016-04-13 17:45:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 17:45:52 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:45:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09eabcb4fbf78aa8eb817c2b566b8984a199f965
Cr-Commit-Position: refs/heads/master@{#12350}

Powered by Google App Engine
This is Rietveld 408576698