Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1884233002: Remove use_openssl from webrtc (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove use_openssl from webrtc This reverts revision 20001 and removes other instances of use_openssl since Chromium is removing the use_openssl flag and iOS no longer ships with NSS as of https://crrev.com/387011. BUG=chromium:601042 R=perkj@webrtc.org, torbjorng@webrtc.org Committed: https://crrev.com/7f7a81991e16ab457c2f2f68ba1431c75381bc34 Cr-Commit-Position: refs/heads/master@{#12414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -43 lines) Patch
M webrtc/base/BUILD.gn View 4 chunks +16 lines, -30 lines 0 comments Download
M webrtc/build/isolate.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/supplement.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
svaldez
4 years, 8 months ago (2016-04-15 20:32:16 UTC) #1
torbjorng (webrtc)
Henrik Kjellander made something identical or at least very similar a few days ago. Adding ...
4 years, 8 months ago (2016-04-15 23:24:51 UTC) #4
kjellander_webrtc
lgtm
4 years, 8 months ago (2016-04-16 18:09:30 UTC) #5
kjellander_webrtc
On 2016/04/15 23:24:51, torbjorng (webrtc) wrote: > Henrik Kjellander made something identical or at least ...
4 years, 8 months ago (2016-04-16 18:12:03 UTC) #6
torbjorng (webrtc)
lgtm
4 years, 8 months ago (2016-04-18 14:03:26 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884233002/1
4 years, 8 months ago (2016-04-18 14:10:12 UTC) #9
perkj_webrtc
On 2016/04/18 14:10:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-04-18 15:20:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884233002/1
4 years, 8 months ago (2016-04-18 15:42:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_clang_dbg on ...
4 years, 8 months ago (2016-04-18 16:10:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884233002/1
4 years, 8 months ago (2016-04-18 16:19:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 18:13:15 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:13:22 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f7a81991e16ab457c2f2f68ba1431c75381bc34
Cr-Commit-Position: refs/heads/master@{#12414}

Powered by Google App Engine
This is Rietveld 408576698