webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h - Issue 1883543002: Revert of Remove the deprecated EncodeInternal interface from AudioEncoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

Issue 1883543002: Revert of Remove the deprecated EncodeInternal interface from AudioEncoder (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.cc ('k') | webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

index 9294f2fed46313691d02ba5830c0cc4ef2204224..3f11af1f9e0c665504520d7a485ecb5a544f487f 100644

--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

@@ -54,6 +54,7 @@

explicit AudioEncoderOpus(const CodecInst& codec_inst);

~AudioEncoderOpus() override;

+ size_t MaxEncodedBytes() const override;

int SampleRateHz() const override;

size_t NumChannels() const override;

size_t Num10MsFramesInNextPacket() const override;

@@ -78,7 +79,7 @@

ApplicationMode application() const { return config_.application; }

bool dtx_enabled() const { return config_.dtx_enabled; }

- protected:

+protected:

EncodedInfo EncodeImpl(uint32_t rtp_timestamp,

rtc::ArrayView<const int16_t> audio,

rtc::Buffer* encoded) override;

@@ -86,7 +87,6 @@

private:

size_t Num10msFramesPerPacket() const;

size_t SamplesPer10msFrame() const;

- size_t ApproximateEncodedBytes() const;

bool RecreateEncoderInstance(const Config& config);

Config config_;