Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1883293003: Cleaned up the EchoSuppression method in the AEC so that it does not have to use the aec state as a… (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@FixGvcBug_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleaned up the EchoSuppression method in the AEC so that it does not have to use the aec state as an input. Furthermore, the debug dump output of e_fft was removed as it is not really used in any analysis scripts. BUG=webrtc:5298 Committed: https://crrev.com/594a877f2dfcb1a746b423e09eb4fba0048899a2 Cr-Commit-Position: refs/heads/master@{#12387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 4 chunks +11 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
peah-webrtc
4 years, 8 months ago (2016-04-15 09:12:00 UTC) #3
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-04-15 10:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883293003/1
4 years, 8 months ago (2016-04-15 18:56:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-04-15 20:57:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883293003/1
4 years, 8 months ago (2016-04-15 21:45:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 8 months ago (2016-04-15 23:46:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883293003/1
4 years, 8 months ago (2016-04-16 11:00:26 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 11:04:01 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 11:04:09 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/594a877f2dfcb1a746b423e09eb4fba0048899a2
Cr-Commit-Position: refs/heads/master@{#12387}

Powered by Google App Engine
This is Rietveld 408576698