Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1883223002: Fix valgrind complaint on uninitialized value (Closed)

Created:
4 years, 8 months ago by Irfan
Modified:
4 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix valgrind complaint on uninitialized value BUG= Committed: https://crrev.com/4d7bc240b960f42d3de415fd33eb4f0af07c41bb Cr-Commit-Position: refs/heads/master@{#12460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/video_coding/utility/frame_dropper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Irfan
4 years, 8 months ago (2016-04-14 17:55:05 UTC) #3
stefan-webrtc
When was this bug introduced? I wonder if this affects Chrome M51?
4 years, 8 months ago (2016-04-19 08:30:11 UTC) #4
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-19 08:30:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883223002/1
4 years, 8 months ago (2016-04-19 14:04:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-19 16:04:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883223002/1
4 years, 8 months ago (2016-04-19 18:54:48 UTC) #11
Irfan
The bug was introduced when I made that change like a month ago or something. ...
4 years, 8 months ago (2016-04-19 18:56:00 UTC) #12
stefan-webrtc
On 2016/04/19 18:56:00, Irfan wrote: > The bug was introduced when I made that change ...
4 years, 8 months ago (2016-04-19 19:11:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-19 20:55:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883223002/1
4 years, 8 months ago (2016-04-21 22:28:50 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 23:37:24 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 23:37:33 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d7bc240b960f42d3de415fd33eb4f0af07c41bb
Cr-Commit-Position: refs/heads/master@{#12460}

Powered by Google App Engine
This is Rietveld 408576698