Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1882963003: Add isolate files for Android tests (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, zhengzhonghou_agora.io, fengyue_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, henrika_webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add isolate files for Android tests BUG=chromium:583318 TESTED=Passing runs with: GYP_DEFINES='test_isolation_mode=prepare OS=android' webrtc/build/gyp_webrtc ninja -C out/Release NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/e532aec25220f94830c538acfeccc2203b6db4f5 Cr-Commit-Position: refs/heads/master@{#12397}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+720 lines, -91 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M setup_links.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/api_tests.gyp View 2 chunks +22 lines, -1 line 0 comments Download
M webrtc/api/peerconnection_unittests.isolate View 1 chunk +6 lines, -24 lines 0 comments Download
A webrtc/api/peerconnection_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 2 comments Download
M webrtc/build/apk_tests.gyp View 4 chunks +31 lines, -31 lines 0 comments Download
M webrtc/common_audio/common_audio.gyp View 1 chunk +22 lines, -1 line 0 comments Download
A webrtc/common_audio/common_audio_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/common_video/common_video_unittests.gyp View 1 chunk +22 lines, -1 line 0 comments Download
A webrtc/common_video/common_video_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/modules/audio_codec_speed_tests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding_tests.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
A webrtc/modules/audio_decoder_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +77 lines, -3 lines 0 comments Download
A webrtc/modules/modules_tests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/modules/modules_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/rtc_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers_tests.gyp View 2 chunks +23 lines, -2 lines 0 comments Download
A webrtc/system_wrappers/system_wrappers_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/test/test.gyp View 2 chunks +23 lines, -2 lines 0 comments Download
A webrtc/test/test_support_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 chunk +21 lines, -0 lines 0 comments Download
A webrtc/tools/tools_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/video_engine_tests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 chunk +21 lines, -0 lines 0 comments Download
A webrtc/voice_engine/voice_engine_unittests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/webrtc_nonparallel_tests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/webrtc_perf_tests_apk.isolate View 1 chunk +26 lines, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
kjellander_webrtc
Anything else needed that you know of stip?
4 years, 8 months ago (2016-04-15 17:22:15 UTC) #8
ghost stip (do not use)
lgtm. are you looking at GN anytime soon? https://chromiumcodereview.appspot.com/1882963003/diff/40001/webrtc/api/peerconnection_unittests_apk.isolate File webrtc/api/peerconnection_unittests_apk.isolate (right): https://chromiumcodereview.appspot.com/1882963003/diff/40001/webrtc/api/peerconnection_unittests_apk.isolate#newcode15 webrtc/api/peerconnection_unittests_apk.isolate:15: '<(PRODUCT_DIR)/bin/run_peerconnection_unittests', ...
4 years, 8 months ago (2016-04-15 18:28:18 UTC) #10
kjellander_webrtc
We only have GN for the production code so far. There are still some pieces ...
4 years, 8 months ago (2016-04-15 18:34:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882963003/40001
4 years, 8 months ago (2016-04-15 18:34:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4855)
4 years, 8 months ago (2016-04-15 18:42:48 UTC) #15
kjellander_webrtc
On 2016/04/15 18:42:48, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-18 03:07:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882963003/40001
4 years, 8 months ago (2016-04-18 03:08:08 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-18 03:08:25 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 03:08:35 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e532aec25220f94830c538acfeccc2203b6db4f5
Cr-Commit-Position: refs/heads/master@{#12397}

Powered by Google App Engine
This is Rietveld 408576698