Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1882923002: Revert of Accept all the media profiles required by JSEP. (Closed)

Created:
4 years, 8 months ago by Zhi Huang
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Accept all the media profiles required by JSEP. (patchset #5 id:80001 of https://codereview.webrtc.org/1880913002/ ) Reason for revert: Broke the Chromium build by introducing static initializers. Original issue's description: > Accept all the media profiles required by JSEP. > > JSEP section 5.1.3 states that: > Any profile matching the following patterns MUST be accepted: > "RTP/[S]AVP[F]" and "(UDP/TCP)/TLS/RTP/SAVP[F]" > > NOTRY=True > BUG=webrtc:5638 > > Committed: https://crrev.com/b7f425ab68ec58e2a5beaaf5ef79f50f1982c6f9 > Cr-Commit-Position: refs/heads/master@{#12338} TBR=deadbeef@webrtc.org,pthatcher@webrtc.org,avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5638 Committed: https://crrev.com/d713e86058c3ba4bbcbf47775d3d01b8ccc14864 Cr-Commit-Position: refs/heads/master@{#12351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -80 lines) Patch
M webrtc/pc/mediasession.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 2 chunks +0 lines, -65 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Zhi Huang
Created Revert of Accept all the media profiles required by JSEP.
4 years, 8 months ago (2016-04-13 17:46:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882923002/1
4 years, 8 months ago (2016-04-13 17:46:24 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-13 17:46:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882923002/1
4 years, 8 months ago (2016-04-13 17:47:11 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-13 17:47:13 UTC) #8
Taylor Brandstetter
lgtm
4 years, 8 months ago (2016-04-13 17:48:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882923002/1
4 years, 8 months ago (2016-04-13 17:48:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 17:48:32 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:48:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d713e86058c3ba4bbcbf47775d3d01b8ccc14864
Cr-Commit-Position: refs/heads/master@{#12351}

Powered by Google App Engine
This is Rietveld 408576698