Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1882733006: Delete I420 encoder and decoder.

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete I420 encoder and decoder. BUG=webrtc:5791

Patch Set 1 #

Patch Set 2 : Fix modules.gyp. Avoid using switch default. #

Patch Set 3 : Delete i420 directory from PRESUBMIT.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -489 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_types.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 3 chunks +0 lines, -18 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/i420.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/i420.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/include/i420.h View 1 chunk +0 lines, -148 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/test/test_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/test/test_util.cc View 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/video_coding/test/tester_main.cc View 2 chunks +1 line, -21 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882733006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882733006/1
4 years, 8 months ago (2016-04-14 12:05:25 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/13889)
4 years, 8 months ago (2016-04-14 12:07:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882733006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882733006/20001
4 years, 8 months ago (2016-04-15 07:46:35 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4816)
4 years, 8 months ago (2016-04-15 07:54:48 UTC) #8
nisse-webrtc
Some questions: 1. Are any applications likely to use these codecs? Any deprecation dances needed? ...
4 years, 8 months ago (2016-04-15 08:50:15 UTC) #11
pbos-webrtc
I think this should instead of being deleted be moved to webrtc/test/fake_encoder.{h,cc} and then in ...
4 years, 8 months ago (2016-04-15 09:10:29 UTC) #12
nisse-webrtc
4 years, 7 months ago (2016-04-27 08:36:26 UTC) #13
On 2016/04/15 09:10:29, pbos-webrtc wrote:
> I think this should instead of being deleted be moved to
> webrtc/test/fake_encoder.{h,cc} and then in the future be wired up to be
usable
> from video_loopback.

Some details: Move the I420 code to webrtc/test/, hook into
video_quality_test.cc:SetupCommon.

Powered by Google App Engine
This is Rietveld 408576698