Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1882083002: Revert of Fix screen capturers to initialize on the same thread on which Start() is called. (Closed)

Created:
4 years, 8 months ago by guidou
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix screen capturers to initialize on the same thread on which Start() is called. (patchset #3 id:80001 of https://codereview.webrtc.org/1861893002/ ) Reason for revert: This is preventing a WebRTC roll into Chromium. See https://codereview.chromium.org/1877263003/ Original issue's description: > Fix screen capturers to initialize on the same thread on which Start() is called. > > Previously screen capturers were initialized when they are created. > This means that in the CRD host they were initialized on the thread > that's different from the thread on which they are used. Because of this > on Linux the host was using XErrorTrap() on two different threads and > this is not supported. Now ScreenCapturer implementations always > initialize themselves on the thread on which Start() is called. > > Also added ThreadChecker to make sure the capturers are always called > from the same thread. > > BUG=600432 > > Committed: https://crrev.com/e8d4b7d8a3d298438a2ebd9ee8d5aa71f42cf033 > Cr-Commit-Position: refs/heads/master@{#12285} TBR=jamiewalch@chromium.org,sergeyu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=600432 Committed: https://crrev.com/63911495de8bb001c3694c174bffdf5a85bb3ad1 Cr-Commit-Position: refs/heads/master@{#12334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -90 lines) Patch
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 13 chunks +40 lines, -45 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 12 chunks +42 lines, -42 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
guidou
Created Revert of Fix screen capturers to initialize on the same thread on which Start() ...
4 years, 8 months ago (2016-04-12 13:31:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882083002/1
4 years, 8 months ago (2016-04-12 13:31:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882083002/1
4 years, 8 months ago (2016-04-12 13:32:00 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/11140)
4 years, 8 months ago (2016-04-12 13:38:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882083002/1
4 years, 8 months ago (2016-04-12 14:15:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-04-12 15:32:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882083002/1
4 years, 8 months ago (2016-04-12 17:09:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882083002/1
4 years, 8 months ago (2016-04-12 18:04:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 18:42:05 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:42:11 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63911495de8bb001c3694c174bffdf5a85bb3ad1
Cr-Commit-Position: refs/heads/master@{#12334}

Powered by Google App Engine
This is Rietveld 408576698