Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1881153003: Moved the aec_rdft*.c files to be built using C++ (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved the aec_rdft*.c files to be build using C++ BUG=webrtc:5298 NOPRESUBMIT=true Committed: https://crrev.com/21a395ddf7136a02f251af3d3198eaaa4f688638 Cr-Commit-Position: refs/heads/master@{#12346}

Patch Set 1 : Moved files, changed build files and removed external includes. #

Patch Set 2 : Rebase with latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2570 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_processing/aec/aec_rdft.c View 1 chunk +0 lines, -589 lines 0 comments Download
A + webrtc/modules/audio_processing/aec/aec_rdft.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/audio_processing/aec/aec_rdft_mips.c View 1 chunk +0 lines, -1187 lines 0 comments Download
A + webrtc/modules/audio_processing/aec/aec_rdft_mips.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/audio_processing/aec/aec_rdft_neon.c View 1 chunk +0 lines, -355 lines 0 comments Download
A + webrtc/modules/audio_processing/aec/aec_rdft_neon.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/audio_processing/aec/aec_rdft_sse2.c View 1 chunk +0 lines, -427 lines 0 comments Download
A + webrtc/modules/audio_processing/aec/aec_rdft_sse2.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
peah-webrtc
4 years, 8 months ago (2016-04-12 21:57:22 UTC) #3
hlundin-webrtc
On 2016/04/12 21:57:22, peah-webrtc wrote: In commit message: build -> built
4 years, 8 months ago (2016-04-13 08:13:38 UTC) #4
hlundin-webrtc
LGTM with the nit in the commit message.
4 years, 8 months ago (2016-04-13 08:14:45 UTC) #5
ivoc
LGTM
4 years, 8 months ago (2016-04-13 08:22:51 UTC) #6
peah-webrtc
On 2016/04/13 08:14:45, hlundin-webrtc wrote: > LGTM with the nit in the commit message. Thanks! ...
4 years, 8 months ago (2016-04-13 13:14:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881153003/20001
4 years, 8 months ago (2016-04-13 13:31:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 14:53:53 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 14:54:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21a395ddf7136a02f251af3d3198eaaa4f688638
Cr-Commit-Position: refs/heads/master@{#12346}

Powered by Google App Engine
This is Rietveld 408576698