Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1881003003: Reland Remove the deprecated EncodeInternal interface from AudioEncoder (Closed)

Created:
4 years, 8 months ago by ossu
Modified:
4 years, 8 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Remove the deprecated EncodeInternal interface from AudioEncoder Remove the deprecated EncodeInternal interface from AudioEncoder Also hid MaxEncodedBytes by making it private. It will get removed as soon as subclasses have had time to remove their overrides. BUG=webrtc:5591 Committed: https://crrev.com/2903ba5ff3cc1aa8fa58aa3fc0f4de53840d97e1 Cr-Commit-Position: refs/heads/master@{#12409}

Patch Set 1 #

Patch Set 2 : Renamed ApproximateEncodedBytes to SufficientOutputBufferSize in Opus #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -278 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 3 chunks +11 lines, -40 lines 1 comment Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 2 chunks +5 lines, -49 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/audio_encoder_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 3 chunks +2 lines, -36 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ossu
Created a new CL for re-landing removing EncodeInternal after dependencies have been fixed.
4 years, 8 months ago (2016-04-15 12:18:50 UTC) #3
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1881003003/diff/20001/webrtc/modules/audio_coding/codecs/audio_encoder.h File webrtc/modules/audio_coding/codecs/audio_encoder.h (right): https://codereview.webrtc.org/1881003003/diff/20001/webrtc/modules/audio_coding/codecs/audio_encoder.h#newcode141 webrtc/modules/audio_coding/codecs/audio_encoder.h:141: // as these subclasses have been given a ...
4 years, 8 months ago (2016-04-15 13:18:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881003003/20001
4 years, 8 months ago (2016-04-18 13:08:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 13:14:37 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 13:14:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2903ba5ff3cc1aa8fa58aa3fc0f4de53840d97e1
Cr-Commit-Position: refs/heads/master@{#12409}

Powered by Google App Engine
This is Rietveld 408576698