Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 1880963002: Generate FMTP parameters for the H.264 codec. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add another TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/media/base/mediaconstants.cc ('K') | « webrtc/media/base/mediaconstants.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index ec6b033d2f7a3862be69a9c25390d646968cfd2c..b9dbd666848a8703e76dc4be1c5623c50ed91bd6 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -386,8 +386,18 @@ std::vector<VideoCodec> DefaultVideoCodecList() {
VideoCodec::CreateRtxCodec(kDefaultRtxVp9PlType, kDefaultVp9PlType));
}
if (CodecIsInternallySupported(kH264CodecName)) {
- codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultH264PlType,
- kH264CodecName));
+ VideoCodec codec = MakeVideoCodecWithDefaultFeedbackParams(
+ kDefaultH264PlType, kH264CodecName);
+ // TODO(hta): Move all parameter generation for SDP into the codec
+ // implementation, for all codecs and parameters.
+ // TODO(hta): Move selection of profile-level-id to H.264 codec
+ // implementation.
+ // TODO(hta): Set FMTP parameters for all codecs of type H264.
+ codec.SetParam(kH264FmtpProfileLevelId,
+ kH264ProfileLevelConstrainedBaseline);
+ codec.SetParam(kH264FmtpLevelAsymmetryAllowed, "1");
juberti2 2016/04/13 20:20:58 You can use the int version here, e.g. 1 instead o
hta-webrtc 2016/04/13 20:43:58 Acknowledged.
+ codec.SetParam(kH264FmtpPacketizationMode, "1");
+ codecs.push_back(codec);
codecs.push_back(
VideoCodec::CreateRtxCodec(kDefaultRtxH264PlType, kDefaultH264PlType));
}
« webrtc/media/base/mediaconstants.cc ('K') | « webrtc/media/base/mediaconstants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698