Generate FMTP parameters for the H.264 codec.

webrtc/api/webrtcsdp_unittest.cc

 /*
  *  Copyright 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "webrtc/api/jsepsessiondescription.h"
 #ifdef WEBRTC_ANDROID
 #include "webrtc/api/test/androidtestinitializer.h"
 #endif
 #include "webrtc/api/webrtcsdp.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/messagedigest.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/base/sslfingerprint.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
 #include "webrtc/media/base/mediaconstants.h"
+#include "webrtc/media/engine/webrtcvideoengine2.h"
+#include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
 #include "webrtc/p2p/base/p2pconstants.h"
 #include "webrtc/pc/mediasession.h"
 
 using cricket::AudioCodec;
 using cricket::AudioContentDescription;
 using cricket::Candidate;
 using cricket::ContentInfo;
 using cricket::CryptoParams;
 using cricket::ContentGroup;
 using cricket::DataCodec;
@@ skipping 2043 matching lines @@
                       "", "", LOCAL_PORT_TYPE, kCandidateGeneration,
                       kCandidateFoundation1);
   candidate.set_tcptype(cricket::TCPTYPE_ACTIVE_STR);
   rtc::scoped_ptr<IceCandidateInterface> jcandidate(
     new JsepIceCandidate(std::string("audio_content_name"), 0, candidate));
 
   std::string message = webrtc::SdpSerializeCandidate(*jcandidate);
   EXPECT_EQ(std::string(kSdpTcpActiveCandidate), message);
 }
 
+TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithH264) {
+  if (webrtc::H264Encoder::IsSupported()) {

[tommi, 2016/04/12 10:10:26]

nit: change to

if (!webrtc::H264Encoder::IsSupported())
  return;

+    for (const auto& codec : cricket::DefaultVideoCodecList()) {
+      video_desc_->AddCodec(codec);
+    }
+    jdesc_.Initialize(desc_.Copy(), kSessionId, kSessionVersion);
+
+    std::string message = webrtc::SdpSerialize(jdesc_, false);
+    size_t after_pt = message.find(" H264/90000");

[hbos, 2016/04/12 10:14:23]

Can we also make sure that the m=video line contains the H264 ID?

[hta-webrtc, 2016/04/12 11:21:37]

Argh. Can do this, but now we're passing the level where it's really proper to
abandon the find/substr method and parse the SDP.
Adding a TODO.

[hbos, 2016/04/12 11:41:14]

Acknowledged.

+    ASSERT_NE(after_pt, std::string::npos);
+    size_t before_pt = message.rfind("a=rtpmap:", after_pt);
+    ASSERT_NE(before_pt, std::string::npos);
+    before_pt += strlen("a=rtpmap:");
+    std::string pt = message.substr(before_pt, after_pt - before_pt);
+    std::string to_find = "a=fmtp:" + pt + " ";
+    size_t fmtp_pos = message.find(to_find);
+    ASSERT_NE(std::string::npos, fmtp_pos) << "Failed to find " << to_find;
+    size_t fmtp_endpos = message.find("\n", fmtp_pos);
+    ASSERT_NE(std::string::npos, fmtp_endpos);
+    std::string fmtp_value = message.substr(fmtp_pos, fmtp_endpos);
+    EXPECT_NE(std::string::npos, fmtp_value.find("level-asymmetry-allowed=1"));
+    EXPECT_NE(std::string::npos, fmtp_value.find("packetization-mode=1"));
+    EXPECT_NE(std::string::npos, fmtp_value.find("profile-level-id=42e01f"));
+    // Provoke an error to verify that test is run.

[tommi, 2016/04/12 10:10:26]

I'm not groking this comment... is it a todo?

[hbos, 2016/04/12 10:14:23]

Old comment that should be removed?

[hta-webrtc, 2016/04/12 11:21:37]

Yep. Done.

+  }

[hbos, 2016/04/12 10:14:23]

Optional: How about logging if the test was skipped due to H264 not being
supported to avoid false positives?

[hta-webrtc, 2016/04/12 11:21:38]

Will only have any effect if people actually look at the logfile.
Skeptical. Advice?

+}
+
 TEST_F(WebRtcSdpTest, DeserializeSessionDescription) {
   JsepSessionDescription jdesc(kDummyString);
   // Deserialize
   EXPECT_TRUE(SdpDeserialize(kSdpFullString, &jdesc));
   // Verify
   EXPECT_TRUE(CompareSessionDescription(jdesc_, jdesc));
 }
 
 TEST_F(WebRtcSdpTest, DeserializeSessionDescriptionWithoutMline) {
   JsepSessionDescription jdesc(kDummyString);
@@ skipping 1011 matching lines @@
   EXPECT_TRUE(
       SdpDeserialize(kUnifiedPlanSdpFullString, &deserialized_description));
 
   EXPECT_TRUE(CompareSessionDescription(jdesc_, deserialized_description));
 }
 
 TEST_F(WebRtcSdpTest, SerializeUnifiedPlanSessionDescription) {
   MakeUnifiedPlanDescription();
   TestSerialize(jdesc_, true);
 }