🏊 Set --shard-timeout in wrapper scripts for apk tests

Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
NOTRY=True

Committed: https://crrev.com/d0554b80687dae53e87c8909e7abb4935634783a
Cr-Commit-Position: refs/heads/master@{#12332}

[agrieve, 2016-04-11 18:17:46]

Description was changed from

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=none
==========

to

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=none
==========

[agrieve, 2016-04-11 18:17:46]

agrieve@chromium.org changed reviewers:
+ kjellander@webrtc.org

[agrieve, 2016-04-11 18:18:51]

On 2016/04/11 18:17:46, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:kjellander@webrtc.org

Depends on https://codereview.chromium.org/1874393002/ being submitted &
rolling, but won't actually break anything since it just sets a variable.

Will wait at least until the dependent CL lands though in case reviewers are not
happy.

[kjellander_webrtc, 2016-04-11 19:31:38]

https://codereview.webrtc.org/1880563002/diff/1/webrtc/build/apk_tests.gyp
File webrtc/build/apk_tests.gyp (right):

https://codereview.webrtc.org/1880563002/diff/1/webrtc/build/apk_tests.gyp#ne...
webrtc/build/apk_tests.gyp:207: 'target_name': 'webrtc_perf_tests_apk',
So, unfortunately this test needs an even longer timeout; the test takes about
30 minutes to run and we only have single-devices for the bots that run these
tests.

Is it possible to set the variable in this local scope for to 2700 seconds, to
match
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
?
I don't remember exactly how GYP deals with the different scopes/overrides for
variables.

[agrieve, 2016-04-11 19:52:16]

Description was changed from

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=none
==========

to

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
==========

[agrieve, 2016-04-11 19:53:02]

https://codereview.webrtc.org/1880563002/diff/1/webrtc/build/apk_tests.gyp
File webrtc/build/apk_tests.gyp (right):

https://codereview.webrtc.org/1880563002/diff/1/webrtc/build/apk_tests.gyp#ne...
webrtc/build/apk_tests.gyp:207: 'target_name': 'webrtc_perf_tests_apk',
On 2016/04/11 19:31:38, kjellander (webrtc) wrote:
> So, unfortunately this test needs an even longer timeout; the test takes about
> 30 minutes to run and we only have single-devices for the bots that run these
> tests.
> 
> Is it possible to set the variable in this local scope for to 2700 seconds, to
> match
>
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
> ?
> I don't remember exactly how GYP deals with the different scopes/overrides for
> variables.

Nice catch! Done (and verified that the override does indeed set it to 2700 in
the script)

[kjellander_webrtc, 2016-04-11 19:55:50]

Awesome. This is very nice to get such configuration closer to the source - and
easier for developers to run the tests! Thanks for doing this.

lgtm but I guess you want to wait for the other CL to land first (and for it to
be rolled in before we deploy the recipe-side changes).

[agrieve, 2016-04-12 13:50:02]

On 2016/04/11 19:55:50, kjellander (webrtc) wrote:
> Awesome. This is very nice to get such configuration closer to the source -
and
> easier for developers to run the tests! Thanks for doing this.
> 
> lgtm but I guess you want to wait for the other CL to land first (and for it
to
> be rolled in before we deploy the recipe-side changes).

Other side is lgtm, so submitting (it's a no-op until the change rolls).

[agrieve, 2016-04-12 13:50:05]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-12 13:50:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880563002/20001

[commit-bot: I haz the power, 2016-04-12 15:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 15:51:03]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[agrieve, 2016-04-12 16:01:18]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-12 16:01:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880563002/20001

[kjellander_webrtc, 2016-04-12 16:41:22]

Description was changed from

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
==========

to

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
NOTRY=True
==========

[kjellander_webrtc, 2016-04-12 16:41:28]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2016-04-12 16:43:10]

On 2016/04/12 16:01:22, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1880563002/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1880563002/20001

We usually have low trybot resources so I set NOTRY=True on this since the
relevant Android trybots have passed.

[kjellander_webrtc, 2016-04-12 16:43:16]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-04-12 16:43:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880563002/20001

[commit-bot: I haz the power, 2016-04-12 16:45:03]

Description was changed from

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
NOTRY=True
==========

to

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
NOTRY=True
==========

[commit-bot: I haz the power, 2016-04-12 16:45:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 16:45:09]

Description was changed from

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
NOTRY=True
==========

to

==========
Set --shard-timeout in wrapper scripts for apk tests

This will allow us to remove this flag from the "how to run the tests"
instructions, and also the bot recipes.

BUG=599919
NOTRY=True

Committed: https://crrev.com/d0554b80687dae53e87c8909e7abb4935634783a
Cr-Commit-Position: refs/heads/master@{#12332}
==========

[commit-bot: I haz the power, 2016-04-12 16:45:10]

Patchset 2 (id:??) landed as
https://crrev.com/d0554b80687dae53e87c8909e7abb4935634783a
Cr-Commit-Position: refs/heads/master@{#12332}