Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1880443002: Fixed rtcp rpsi parsing of invalid packets. (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed rtcp rpsi parsing of invalid packets. Added packet type RpsiItem to destinguish parsed rpsi header and Rpsi body preventing handling two half-valid (header-only) rpsi packets as one valid, making test parser calculate rpsi packet once instead of twice. Added check padding bits doesn't exceed native bit string length. Marking rpsi received moved after it is validated. BUG=600977 Committed: https://crrev.com/90a1351072a42f0b835f1c759f969ea014ce6b7f Cr-Commit-Position: refs/heads/master@{#12318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -4 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.cc View 1 chunk +9 lines, -1 line 0 comments Download
M webrtc/test/rtcp_packet_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
danilchap
Same tests as in https://codereview.webrtc.org/1870573004/, different approach to fix.
4 years, 8 months ago (2016-04-11 11:27:07 UTC) #2
åsapersson
lgtm
4 years, 8 months ago (2016-04-11 15:36:02 UTC) #3
pbos-webrtc
webrtc/test lgtm
4 years, 8 months ago (2016-04-11 16:10:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880443002/1
4 years, 8 months ago (2016-04-11 16:46:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 17:05:05 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 17:05:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90a1351072a42f0b835f1c759f969ea014ce6b7f
Cr-Commit-Position: refs/heads/master@{#12318}

Powered by Google App Engine
This is Rietveld 408576698