webrtc/common_video/i420_video_frame_unittest.cc - Issue 1878623002: Added new VideoFrameBuffer methods Data[YUV]() etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/i420_video_frame_unittest.cc

Issue 1878623002: Added new VideoFrameBuffer methods Data[YUV]() etc. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Add NOLINT for the unusual combination virtual final. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_video/i420_buffer_pool_unittest.cc ('k') | webrtc/common_video/include/video_frame_buffer.h » ('j') | webrtc/common_video/include/video_frame_buffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_video/i420_video_frame_unittest.cc

diff --git a/webrtc/common_video/i420_video_frame_unittest.cc b/webrtc/common_video/i420_video_frame_unittest.cc

index 9b2bdd762dca60f6e1c8ebca1124a24ca1245f31..cd6c686b2eea0021921d1d8d5028bd71b00eabce 100644

--- a/webrtc/common_video/i420_video_frame_unittest.cc

+++ b/webrtc/common_video/i420_video_frame_unittest.cc

@@ -257,9 +257,9 @@ TEST(TestVideoFrame, TextureInitialValues) {

TEST(TestI420FrameBuffer, Copy) {

rtc::scoped_refptr<I420Buffer> buf1(

new rtc::RefCountedObject<I420Buffer>(20, 10));

- memset(buf1->MutableData(kYPlane), 1, 200);

- memset(buf1->MutableData(kUPlane), 2, 50);

- memset(buf1->MutableData(kVPlane), 3, 50);

+ memset(buf1->MutableDataY(), 1, 200);

+ memset(buf1->MutableDataU(), 2, 50);

+ memset(buf1->MutableDataV(), 3, 50);

rtc::scoped_refptr<I420Buffer> buf2 = I420Buffer::Copy(buf1);

EXPECT_TRUE(test::FrameBufsEqual(buf1, buf2));

}