| OLD | NEW |
| 1 /* | 1 /* |
| 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. | 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
| 5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
| 6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
| 7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
| 8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
| 9 */ | 9 */ |
| 10 | 10 |
| 11 #include <string> | 11 #include <string> |
| 12 | 12 |
| 13 #include "testing/gtest/include/gtest/gtest.h" | 13 #include "testing/gtest/include/gtest/gtest.h" |
| 14 #include "webrtc/common_video/include/i420_buffer_pool.h" | 14 #include "webrtc/common_video/include/i420_buffer_pool.h" |
| 15 | 15 |
| 16 namespace webrtc { | 16 namespace webrtc { |
| 17 | 17 |
| 18 TEST(TestI420BufferPool, SimpleFrameReuse) { | 18 TEST(TestI420BufferPool, SimpleFrameReuse) { |
| 19 I420BufferPool pool; | 19 I420BufferPool pool; |
| 20 rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16); | 20 rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16); |
| 21 EXPECT_EQ(16, buffer->width()); | 21 EXPECT_EQ(16, buffer->width()); |
| 22 EXPECT_EQ(16, buffer->height()); | 22 EXPECT_EQ(16, buffer->height()); |
| 23 // Extract non-refcounted pointers for testing. | 23 // Extract non-refcounted pointers for testing. |
| 24 const uint8_t* y_ptr = buffer->data(kYPlane); | 24 const uint8_t* y_ptr = buffer->DataY(); |
| 25 const uint8_t* u_ptr = buffer->data(kUPlane); | 25 const uint8_t* u_ptr = buffer->DataU(); |
| 26 const uint8_t* v_ptr = buffer->data(kVPlane); | 26 const uint8_t* v_ptr = buffer->DataV(); |
| 27 // Release buffer so that it is returned to the pool. | 27 // Release buffer so that it is returned to the pool. |
| 28 buffer = nullptr; | 28 buffer = nullptr; |
| 29 // Check that the memory is resued. | 29 // Check that the memory is resued. |
| 30 buffer = pool.CreateBuffer(16, 16); | 30 buffer = pool.CreateBuffer(16, 16); |
| 31 EXPECT_EQ(y_ptr, buffer->data(kYPlane)); | 31 EXPECT_EQ(y_ptr, buffer->DataY()); |
| 32 EXPECT_EQ(u_ptr, buffer->data(kUPlane)); | 32 EXPECT_EQ(u_ptr, buffer->DataU()); |
| 33 EXPECT_EQ(v_ptr, buffer->data(kVPlane)); | 33 EXPECT_EQ(v_ptr, buffer->DataV()); |
| 34 EXPECT_EQ(16, buffer->width()); | 34 EXPECT_EQ(16, buffer->width()); |
| 35 EXPECT_EQ(16, buffer->height()); | 35 EXPECT_EQ(16, buffer->height()); |
| 36 } | 36 } |
| 37 | 37 |
| 38 TEST(TestI420BufferPool, FailToReuse) { | 38 TEST(TestI420BufferPool, FailToReuse) { |
| 39 I420BufferPool pool; | 39 I420BufferPool pool; |
| 40 rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16); | 40 rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16); |
| 41 // Extract non-refcounted pointers for testing. | 41 // Extract non-refcounted pointers for testing. |
| 42 const uint8_t* u_ptr = buffer->data(kUPlane); | 42 const uint8_t* u_ptr = buffer->DataU(); |
| 43 const uint8_t* v_ptr = buffer->data(kVPlane); | 43 const uint8_t* v_ptr = buffer->DataV(); |
| 44 // Release buffer so that it is returned to the pool. | 44 // Release buffer so that it is returned to the pool. |
| 45 buffer = nullptr; | 45 buffer = nullptr; |
| 46 // Check that the pool doesn't try to reuse buffers of incorrect size. | 46 // Check that the pool doesn't try to reuse buffers of incorrect size. |
| 47 buffer = pool.CreateBuffer(32, 16); | 47 buffer = pool.CreateBuffer(32, 16); |
| 48 EXPECT_EQ(32, buffer->width()); | 48 EXPECT_EQ(32, buffer->width()); |
| 49 EXPECT_EQ(16, buffer->height()); | 49 EXPECT_EQ(16, buffer->height()); |
| 50 EXPECT_NE(u_ptr, buffer->data(kUPlane)); | 50 EXPECT_NE(u_ptr, buffer->DataU()); |
| 51 EXPECT_NE(v_ptr, buffer->data(kVPlane)); | 51 EXPECT_NE(v_ptr, buffer->DataV()); |
| 52 } | 52 } |
| 53 | 53 |
| 54 TEST(TestI420BufferPool, ExclusiveOwner) { | 54 TEST(TestI420BufferPool, ExclusiveOwner) { |
| 55 // Check that created buffers are exclusive so that they can be written to. | 55 // Check that created buffers are exclusive so that they can be written to. |
| 56 I420BufferPool pool; | 56 I420BufferPool pool; |
| 57 rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16); | 57 rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16); |
| 58 EXPECT_TRUE(buffer->IsMutable()); | 58 EXPECT_TRUE(buffer->IsMutable()); |
| 59 } | 59 } |
| 60 | 60 |
| 61 TEST(TestI420BufferPool, FrameValidAfterPoolDestruction) { | 61 TEST(TestI420BufferPool, FrameValidAfterPoolDestruction) { |
| 62 rtc::scoped_refptr<VideoFrameBuffer> buffer; | 62 rtc::scoped_refptr<VideoFrameBuffer> buffer; |
| 63 { | 63 { |
| 64 I420BufferPool pool; | 64 I420BufferPool pool; |
| 65 buffer = pool.CreateBuffer(16, 16); | 65 buffer = pool.CreateBuffer(16, 16); |
| 66 } | 66 } |
| 67 EXPECT_TRUE(buffer->IsMutable()); | 67 EXPECT_TRUE(buffer->IsMutable()); |
| 68 EXPECT_EQ(16, buffer->width()); | 68 EXPECT_EQ(16, buffer->width()); |
| 69 EXPECT_EQ(16, buffer->height()); | 69 EXPECT_EQ(16, buffer->height()); |
| 70 // Try to trigger use-after-free errors by writing to y-plane. | 70 // Try to trigger use-after-free errors by writing to y-plane. |
| 71 memset(buffer->MutableData(kYPlane), 0xA5, 16 * buffer->stride(kYPlane)); | 71 memset(buffer->MutableDataY(), 0xA5, 16 * buffer->StrideY()); |
| 72 } | 72 } |
| 73 | 73 |
| 74 } // namespace webrtc | 74 } // namespace webrtc |
| OLD | NEW |