Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: webrtc/common_video/i420_buffer_pool.cc

Issue 1878623002: Added new VideoFrameBuffer methods Data[YUV]() etc. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add NOLINT for the unusual combination virtual final. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/common_video/include/i420_buffer_pool.h" 11 #include "webrtc/common_video/include/i420_buffer_pool.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 14
15 namespace { 15 namespace {
16 16
17 // One extra indirection is needed to make |HasOneRef| work. 17 // One extra indirection is needed to make |HasOneRef| work.
18 class PooledI420Buffer : public webrtc::VideoFrameBuffer { 18 class PooledI420Buffer : public webrtc::VideoFrameBuffer {
19 public: 19 public:
20 explicit PooledI420Buffer( 20 explicit PooledI420Buffer(
21 const rtc::scoped_refptr<webrtc::I420Buffer>& buffer) 21 const rtc::scoped_refptr<webrtc::I420Buffer>& buffer)
22 : buffer_(buffer) {} 22 : buffer_(buffer) {}
23 23
24 private: 24 private:
25 ~PooledI420Buffer() override {} 25 ~PooledI420Buffer() override {}
26 26
27 int width() const override { return buffer_->width(); } 27 int width() const override { return buffer_->width(); }
28 int height() const override { return buffer_->height(); } 28 int height() const override { return buffer_->height(); }
29 const uint8_t* data(webrtc::PlaneType type) const override { 29 const uint8_t* DataY() const override { return buffer_->DataY(); }
30 return buffer_->data(type); 30 const uint8_t* DataU() const override { return buffer_->DataU(); }
31 const uint8_t* DataV() const override { return buffer_->DataV(); }
32
33 // Make the HasOneRef() check here instead of in |buffer_|, because the pool
34 // also has a reference to |buffer_|.
35 uint8_t* MutableDataY() override {
36 RTC_DCHECK(HasOneRef());
37 return const_cast<uint8_t*>(buffer_->DataY());
31 } 38 }
32 uint8_t* MutableData(webrtc::PlaneType type) override { 39 uint8_t* MutableDataU() override {
33 // Make the HasOneRef() check here instead of in |buffer_|, because the pool
34 // also has a reference to |buffer_|.
35 RTC_DCHECK(HasOneRef()); 40 RTC_DCHECK(HasOneRef());
36 return const_cast<uint8_t*>(buffer_->data(type)); 41 return const_cast<uint8_t*>(buffer_->DataU());
37 } 42 }
38 int stride(webrtc::PlaneType type) const override { 43 uint8_t* MutableDataV() override {
39 return buffer_->stride(type); 44 RTC_DCHECK(HasOneRef());
45 return const_cast<uint8_t*>(buffer_->DataV());
40 } 46 }
47 int StrideY() const override { return buffer_->StrideY(); }
48 int StrideU() const override { return buffer_->StrideU(); }
49 int StrideV() const override { return buffer_->StrideV(); }
41 void* native_handle() const override { return nullptr; } 50 void* native_handle() const override { return nullptr; }
42 51
43 rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override { 52 rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override {
44 RTC_NOTREACHED(); 53 RTC_NOTREACHED();
45 return nullptr; 54 return nullptr;
46 } 55 }
47 56
48 friend class rtc::RefCountedObject<PooledI420Buffer>; 57 friend class rtc::RefCountedObject<PooledI420Buffer>;
49 rtc::scoped_refptr<webrtc::I420Buffer> buffer_; 58 rtc::scoped_refptr<webrtc::I420Buffer> buffer_;
50 }; 59 };
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 // Allocate new buffer. 95 // Allocate new buffer.
87 rtc::scoped_refptr<I420Buffer> buffer = new rtc::RefCountedObject<I420Buffer>( 96 rtc::scoped_refptr<I420Buffer> buffer = new rtc::RefCountedObject<I420Buffer>(
88 width, height); 97 width, height);
89 if (zero_initialize_) 98 if (zero_initialize_)
90 buffer->InitializeData(); 99 buffer->InitializeData();
91 buffers_.push_back(buffer); 100 buffers_.push_back(buffer);
92 return new rtc::RefCountedObject<PooledI420Buffer>(buffers_.back()); 101 return new rtc::RefCountedObject<PooledI420Buffer>(buffers_.back());
93 } 102 }
94 103
95 } // namespace webrtc 104 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/common_video/i420_buffer_pool_unittest.cc » ('j') | webrtc/common_video/include/video_frame_buffer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698