Chromium Code Reviews

Issue 1878613002: Changed the delay estimator to be built using C++ (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed the delay estimator to be built using C++ BUG=webrtc:5724 NOPRESUBMIT=true Committed: https://crrev.com/bdb7af692f48d4cf2a2e7d13c053facdc57df99a Cr-Commit-Position: refs/heads/master@{#12336}

Patch Set 1 : Changed file endings to .cc and updated the buildfiles accordingly #

Patch Set 2 : Corrected all Cpp build errors #

Total comments: 2

Patch Set 3 : Moved include file inclusion #

Patch Set 4 : Rebase with latest master #

Unified diffs Side-by-side diffs Stats (+34 lines, -1204 lines)
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/modules/audio_processing/aecm/aecm_core.cc View 1 chunk +2 lines, -1 line 0 comments
M webrtc/modules/audio_processing/aecm/aecm_core_c.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/modules/audio_processing/aecm/aecm_core_mips.cc View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +2 lines, -2 lines 0 comments
D webrtc/modules/audio_processing/utility/delay_estimator.c View 1 chunk +0 lines, -684 lines 0 comments
A + webrtc/modules/audio_processing/utility/delay_estimator.cc View 5 chunks +17 lines, -14 lines 0 comments
M webrtc/modules/audio_processing/utility/delay_estimator_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments
D webrtc/modules/audio_processing/utility/delay_estimator_wrapper.c View 1 chunk +0 lines, -485 lines 0 comments
A + webrtc/modules/audio_processing/utility/delay_estimator_wrapper.cc View 7 chunks +10 lines, -9 lines 0 comments

Messages

Total messages: 27 (14 generated)
peah-webrtc
4 years, 8 months ago (2016-04-11 15:50:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878613002/40001
4 years, 8 months ago (2016-04-11 15:57:18 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4717)
4 years, 8 months ago (2016-04-11 16:13:32 UTC) #8
hlundin-webrtc
LGTM with one comment. https://codereview.webrtc.org/1878613002/diff/40001/webrtc/modules/audio_processing/aecm/aecm_core.cc File webrtc/modules/audio_processing/aecm/aecm_core.cc (right): https://codereview.webrtc.org/1878613002/diff/40001/webrtc/modules/audio_processing/aecm/aecm_core.cc#newcode21 webrtc/modules/audio_processing/aecm/aecm_core.cc:21: #include "webrtc/system_wrappers/include/cpu_features_wrapper.h" Wrong order of ...
4 years, 8 months ago (2016-04-12 06:54:12 UTC) #9
ivoc
LGTM.
4 years, 8 months ago (2016-04-12 07:26:45 UTC) #10
peah-webrtc
https://codereview.webrtc.org/1878613002/diff/40001/webrtc/modules/audio_processing/aecm/aecm_core.cc File webrtc/modules/audio_processing/aecm/aecm_core.cc (right): https://codereview.webrtc.org/1878613002/diff/40001/webrtc/modules/audio_processing/aecm/aecm_core.cc#newcode21 webrtc/modules/audio_processing/aecm/aecm_core.cc:21: #include "webrtc/system_wrappers/include/cpu_features_wrapper.h" On 2016/04/12 06:54:12, hlundin-webrtc wrote: > Wrong ...
4 years, 8 months ago (2016-04-12 11:53:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878613002/80001
4 years, 8 months ago (2016-04-12 11:53:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4743)
4 years, 8 months ago (2016-04-12 12:00:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878613002/80001
4 years, 8 months ago (2016-04-12 13:16:03 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-12 13:54:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878613002/80001
4 years, 8 months ago (2016-04-12 21:47:23 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-12 21:47:48 UTC) #25
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 21:47:54 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bdb7af692f48d4cf2a2e7d13c053facdc57df99a
Cr-Commit-Position: refs/heads/master@{#12336}

Powered by Google App Engine