Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1878533002:
Store reverse output rate and number of channels in APM protobuf recordings (Closed)
|
Created:
4 years, 8 months ago by peah-webrtc Modified:
4 years, 8 months ago CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded storing of the reverse output rate and number of channels in APM protobuf recordings.
Support for reading the newly added fields will be added in a another CL.
BUG=webrtc:5759, webrtc:5724
Committed: https://crrev.com/c7bdf8a729323dc1587371ec417bf956238d5877
Cr-Commit-Position: refs/heads/master@{#12316}
Patch Set 1 #
Messages
Total messages: 21 (9 generated)
Description was changed from ========== Added storing of the reverse output rate and number of channels in the APM protobuf recordings. BUG=webrtc:5759, webrtc:5724 ========== to ========== Added storing of the reverse output rate and number of channels in the APM protobuf recordings. Support for reading the newly added fields will be added in a follow-up CL. BUG=webrtc:5759, webrtc:5724 ==========
Description was changed from ========== Added storing of the reverse output rate and number of channels in the APM protobuf recordings. Support for reading the newly added fields will be added in a follow-up CL. BUG=webrtc:5759, webrtc:5724 ========== to ========== Added storing of the reverse output rate and number of channels in the APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 ==========
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org, ivoc@webrtc.org
On 2016/04/11 05:32:07, peah-webrtc wrote: Drive-by suggestion for commit message first line: "Store reverse output rate and number of channels in APM protobuf recordings"
On 2016/04/11 07:02:01, kwiberg-webrtc wrote: > On 2016/04/11 05:32:07, peah-webrtc wrote: > > Drive-by suggestion for commit message first line: "Store reverse output rate > and number of channels in APM protobuf recordings" Thanks :-)
LGTM.
Description was changed from ========== Added storing of the reverse output rate and number of channels in the APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 ========== to ========== Added storing of the reverse output rate and number of channels in APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 ==========
minyue@webrtc.org changed reviewers: + minyue@webrtc.org
no need to change unpack?
On 2016/04/11 07:48:53, minyue-webrtc wrote: > no need to change unpack? No, we don't since this affects how the internal processing is done in APM and nothing on how the data is extracted from unpack. The audioproc/audioproc_f processing should, however, be corrected so as to take this into account, and that is the upcoming CL being mentioned.
On 2016/04/11 07:48:53, minyue-webrtc wrote: > no need to change unpack? No, we don't since this affects how the internal processing is done in APM and nothing on how the data is extracted from unpack. The audioproc/audioproc_f processing should, however, be corrected so as to take this into account, and that is the upcoming CL being mentioned.
henrik.lundin@webrtc.org changed reviewers: - henrik.lundin@webrtc.org
Removing myself. You don't need my rubber-stamp approval on this.
lgtm
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878533002/1
Message was sent while issue was closed.
Description was changed from ========== Added storing of the reverse output rate and number of channels in APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 ========== to ========== Added storing of the reverse output rate and number of channels in APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Added storing of the reverse output rate and number of channels in APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 ========== to ========== Added storing of the reverse output rate and number of channels in APM protobuf recordings. Support for reading the newly added fields will be added in a another CL. BUG=webrtc:5759, webrtc:5724 Committed: https://crrev.com/c7bdf8a729323dc1587371ec417bf956238d5877 Cr-Commit-Position: refs/heads/master@{#12316} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c7bdf8a729323dc1587371ec417bf956238d5877 Cr-Commit-Position: refs/heads/master@{#12316} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
