Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: webrtc/modules/audio_processing/audio_processing.gypi

Issue 1877713002: Replaced the data logging functionality in the AEC with a generic logging functionality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase with latest master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing.gypi
diff --git a/webrtc/modules/audio_processing/audio_processing.gypi b/webrtc/modules/audio_processing/audio_processing.gypi
index fd41eea48c77fab35c6d64ea7c7616d6b4655bb7..4ee6c5c3c1e25f751563538ac3d505776a642349 100644
--- a/webrtc/modules/audio_processing/audio_processing.gypi
+++ b/webrtc/modules/audio_processing/audio_processing.gypi
@@ -9,6 +9,8 @@
{
'variables': {
'shared_generated_dir': '<(SHARED_INTERMEDIATE_DIR)/audio_processing/asm_offsets',
+ # Outputs some low-level debug files.
+ 'aec_debug_dump%': 0,
},
'targets': [
{
@@ -16,7 +18,6 @@
'type': 'static_library',
'variables': {
# Outputs some low-level debug files.
- 'aec_debug_dump%': 0,
'agc_debug_dump%': 0,
# Disables the usual mode where we trust the reported system delay
@@ -91,9 +92,8 @@
'intelligibility/intelligibility_utils.h',
'level_estimator_impl.cc',
'level_estimator_impl.h',
- 'logging/aec_logging.h',
- 'logging/aec_logging_file_handling.cc',
- 'logging/aec_logging_file_handling.h',
+ 'logging/apm_data_dumper.cc',
+ 'logging/apm_data_dumper.h',
'noise_suppression_impl.cc',
'noise_suppression_impl.h',
'render_queue_item_verifier.h',
@@ -150,7 +150,9 @@
],
'conditions': [
['aec_debug_dump==1', {
- 'defines': ['WEBRTC_AEC_DEBUG_DUMP',],
+ 'defines': ['WEBRTC_AEC_DEBUG_DUMP=1',],
+ }, {
+ 'defines': ['WEBRTC_AEC_DEBUG_DUMP=0',],
}],
['aec_untrusted_delay_for_testing==1', {
'defines': ['WEBRTC_UNTRUSTED_DELAY',],
@@ -249,6 +251,11 @@
'aec/aec_rdft_sse2.cc',
],
'conditions': [
+ ['aec_debug_dump==1', {
+ 'defines': ['WEBRTC_AEC_DEBUG_DUMP=1',],
+ }, {
+ 'defines': ['WEBRTC_AEC_DEBUG_DUMP=0',],
+ }],
['os_posix==1', {
'cflags': [ '-msse2', ],
'xcode_settings': {
@@ -273,6 +280,14 @@
'aecm/aecm_core_neon.cc',
'ns/nsx_core_neon.c',
],
+ 'conditions': [
+ ['aec_debug_dump==1', {
+ 'defines': ['WEBRTC_AEC_DEBUG_DUMP=1',],
+ }],
+ ['aec_debug_dump==0', {
+ 'defines': ['WEBRTC_AEC_DEBUG_DUMP=0',],
+ }],
+ ],
}],
}],
],

Powered by Google App Engine
This is Rietveld 408576698