Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1877643002: Fix RTCAudioSession crash in removeDelegate. (Closed)

Created:
4 years, 8 months ago by tkchin_webrtc
Modified:
4 years, 8 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix RTCAudioSession crash in removeDelegate. BUG= Committed: https://crrev.com/efdd930dc9f091e0144b2b4695f970450631dde4 Cr-Commit-Position: refs/heads/master@{#12320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm View 2 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm View 3 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkchin_webrtc
4 years, 8 months ago (2016-04-09 01:12:12 UTC) #3
Chuck
lgtm
4 years, 8 months ago (2016-04-11 14:02:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877643002/1
4 years, 8 months ago (2016-04-11 17:10:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 19:01:03 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 19:01:14 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/efdd930dc9f091e0144b2b4695f970450631dde4
Cr-Commit-Position: refs/heads/master@{#12320}

Powered by Google App Engine
This is Rietveld 408576698