Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1877253002: Replaced CriticalSectionWrapper with rtc::CriticalSection in rtp_rtcp module (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replaced CriticalSectionWrapper with rtc::CriticalSection in rtp_rtcp module Committed: https://crrev.com/7c9426cf38caffd5d2ed7b390188c84ba8e39bf7 Cr-Commit-Position: refs/heads/master@{#12359}

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl format dtmf_queue.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -261 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 4 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/bitrate.h View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/bitrate.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/dtmf_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/dtmf_queue.cc View 1 3 chunks +6 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_receiver_impl.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 3 chunks +5 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 21 chunks +25 lines, -29 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 27 chunks +28 lines, -35 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_parser.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 9 chunks +7 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 11 chunks +16 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 7 chunks +9 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 10 chunks +13 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 9 chunks +8 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 10 chunks +10 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 7 chunks +8 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.cc View 9 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
danilchap
4 years, 8 months ago (2016-04-12 09:00:07 UTC) #2
pbos-webrtc
lgtm https://codereview.webrtc.org/1877253002/diff/1/webrtc/modules/rtp_rtcp/source/dtmf_queue.cc File webrtc/modules/rtp_rtcp/source/dtmf_queue.cc (right): https://codereview.webrtc.org/1877253002/diff/1/webrtc/modules/rtp_rtcp/source/dtmf_queue.cc#newcode17 webrtc/modules/rtp_rtcp/source/dtmf_queue.cc:17: : next_empty_index_(0) { git cl format plz
4 years, 8 months ago (2016-04-12 09:08:43 UTC) #4
danilchap
https://codereview.webrtc.org/1877253002/diff/1/webrtc/modules/rtp_rtcp/source/dtmf_queue.cc File webrtc/modules/rtp_rtcp/source/dtmf_queue.cc (right): https://codereview.webrtc.org/1877253002/diff/1/webrtc/modules/rtp_rtcp/source/dtmf_queue.cc#newcode17 webrtc/modules/rtp_rtcp/source/dtmf_queue.cc:17: : next_empty_index_(0) { On 2016/04/12 09:08:43, pbos-webrtc wrote: > ...
4 years, 8 months ago (2016-04-12 09:14:40 UTC) #5
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-14 09:05:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877253002/20001
4 years, 8 months ago (2016-04-14 09:06:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 10:05:35 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 10:05:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c9426cf38caffd5d2ed7b390188c84ba8e39bf7
Cr-Commit-Position: refs/heads/master@{#12359}

Powered by Google App Engine
This is Rietveld 408576698