Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876773002: Enable proxy_unittest (thread proxy tests). (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 8 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable proxy_unittest (thread proxy tests). BUG=webrtc:5426 Committed: https://crrev.com/25ed5800b93a2d6040f4fdfeae64cb3629e3f277 Cr-Commit-Position: refs/heads/master@{#12314}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove commented out peerconnectionproxy_unittest.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/api_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
nisse-webrtc
Please.
4 years, 8 months ago (2016-04-11 11:29:31 UTC) #2
perkj_webrtc
lgtm with the below addressed. https://codereview.webrtc.org/1876773002/diff/1/webrtc/api/api_tests.gyp File webrtc/api/api_tests.gyp (right): https://codereview.webrtc.org/1876773002/diff/1/webrtc/api/api_tests.gyp#newcode46 webrtc/api/api_tests.gyp:46: # 'peerconnectionproxy_unittest.cc', can you ...
4 years, 8 months ago (2016-04-11 11:49:41 UTC) #3
nisse-webrtc
https://codereview.webrtc.org/1876773002/diff/1/webrtc/api/api_tests.gyp File webrtc/api/api_tests.gyp (right): https://codereview.webrtc.org/1876773002/diff/1/webrtc/api/api_tests.gyp#newcode46 webrtc/api/api_tests.gyp:46: # 'peerconnectionproxy_unittest.cc', On 2016/04/11 11:49:40, perkj_webrtc wrote: > can ...
4 years, 8 months ago (2016-04-11 12:04:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876773002/20001
4 years, 8 months ago (2016-04-11 12:04:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 13:01:32 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 13:01:40 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/25ed5800b93a2d6040f4fdfeae64cb3629e3f277
Cr-Commit-Position: refs/heads/master@{#12314}

Powered by Google App Engine
This is Rietveld 408576698