Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1876233002: Add test annotations to AppRTCDemoTest. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add test annotations to AppRTCDemoTest. After rolling in https://codereview.webrtc.org/1847963004 the AppRTCDemoTest started running 0 tests due to https://crbug.com/601464. Adding test annotations makes the tests being executed again. BUG=chromium:601464 NOTRY=True Committed: https://crrev.com/9c4fadc1997e99f1ba48408fc4ee8910f4cbcae1 Cr-Commit-Position: refs/heads/master@{#12325}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/LooperExecutorTest.java View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 11 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kjellander_webrtc
This should bring back this important test.
4 years, 8 months ago (2016-04-11 19:23:39 UTC) #5
AlexG
lgtm
4 years, 8 months ago (2016-04-11 21:17:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876233002/40001
4 years, 8 months ago (2016-04-12 04:26:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-12 04:27:36 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 04:27:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c4fadc1997e99f1ba48408fc4ee8910f4cbcae1
Cr-Commit-Position: refs/heads/master@{#12325}

Powered by Google App Engine
This is Rietveld 408576698