Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876143002: Corrected include of C++ header file in AECM that was done using external inclusion (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Corrected include of C++ header file in AECM that was done using external inclusion BUG= Committed: https://crrev.com/b97526ed651679789d14780ba3c636af83feafd7 Cr-Commit-Position: refs/heads/master@{#12327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_processing/aecm/aecm_core.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
peah-webrtc
4 years, 8 months ago (2016-04-11 15:55:55 UTC) #2
ivoc
LGTM.
4 years, 8 months ago (2016-04-12 07:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876143002/1
4 years, 8 months ago (2016-04-12 07:21:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 08:20:47 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:20:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b97526ed651679789d14780ba3c636af83feafd7
Cr-Commit-Position: refs/heads/master@{#12327}

Powered by Google App Engine
This is Rietveld 408576698