Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1875873002:
Filter out undesired initial -1 values. (Closed)
DescriptionFilter out some variables with initial -1 in the stats report.
If we call GetStats in PeerConnection before receiving the remote answer, we will get some variables in the StatsReports which are initially set to be -1.
Several conditions are added when extracting the info for the report in StatsCollector.
Those variables include:
gooRtt,
dataChannelId,
googEchoCancellationEchoDelayMedian,
googEchoCancellationEchoQualityMin,
googEchoCancellationEchoDelayStdDev,
googJitterReceived,
audioInputLevel,
googCaptureStartNtpTimeMs
packetsLost.
BUG=webrtc:3377
Committed: https://crrev.com/6ba3b1976f3d8298450ac89697868d1ee0b6c66a
Cr-Commit-Position: refs/heads/master@{#12735}
Patch Set 1 #Patch Set 2 : Add a unit test for StatsCollector. #Patch Set 3 : Filter out other undesired initial -1. #Patch Set 4 : Fix the unit test after merge. #Messages
Total messages: 22 (12 generated)
Description was changed from ========== Hide the initial value of gooRtt. Hide the initial value(-1) of googRtt in the Stats. BUG=webrtc:3377 ========== to ========== Hide the initial value of gooRtt. Hide the initial value(-1) of googRtt in the Stats. BUG=webrtc:3377 ==========
Description was changed from ========== Hide the initial value of gooRtt. Hide the initial value(-1) of googRtt in the Stats. BUG=webrtc:3377 ========== to ========== Hide the initial value(-1) of googRtt in the Stats. The rtt value would be -1 if we call GetStats in PeerConnection before receiving the remove answer which is not desired. One condition is added in this patch. The negative rtt value will be filtered out when extracting the common sender info. BUG=webrtc:3377 ==========
Description was changed from ========== Hide the initial value(-1) of googRtt in the Stats. The rtt value would be -1 if we call GetStats in PeerConnection before receiving the remove answer which is not desired. One condition is added in this patch. The negative rtt value will be filtered out when extracting the common sender info. BUG=webrtc:3377 ========== to ========== Hide the initial value(-1) of googRtt in the Stats. The rtt value would be -1 if we call GetStats in PeerConnection before receiving the remote answer which is not desired. One condition is added in this patch. The negative rtt value will be filtered out when extracting the common sender info. BUG=webrtc:3377 ==========
Description was changed from ========== Hide the initial value(-1) of googRtt in the Stats. The rtt value would be -1 if we call GetStats in PeerConnection before receiving the remote answer which is not desired. One condition is added in this patch. The negative rtt value will be filtered out when extracting the common sender info. BUG=webrtc:3377 ========== to ========== Hide the initial value(-1) of googRtt in the stats report. The rtt value would be -1 if we call GetStats in PeerConnection before receiving the remote answer. The -1 is not desired. One condition is added in this patch. The negative rtt value will be filtered out when extracting the common sender info. BUG=webrtc:3377 ==========
zhihuang@webrtc.org changed reviewers: + deadbeef@webrtc.org, pthatcher@webrtc.org
I think there are some other stats that are -1 initially. Some I found: datachannelid packetsLost googEchoCancellationEchoDelayMedian googEchoCancellationEchoQualityMin googEchoCancellationEchoDelayStdDev googJitterReceived Can you try to find the other stats that this bug applies to, and apply the same logic?
On 2016/04/23 00:18:14, Taylor Brandstetter wrote: > I think there are some other stats that are -1 initially. > > Some I found: > datachannelid > packetsLost > googEchoCancellationEchoDelayMedian > googEchoCancellationEchoQualityMin > googEchoCancellationEchoDelayStdDev > googJitterReceived > > Can you try to find the other stats that this bug applies to, and apply the same > logic? Sure, I can do that.
Description was changed from ========== Hide the initial value(-1) of googRtt in the stats report. The rtt value would be -1 if we call GetStats in PeerConnection before receiving the remote answer. The -1 is not desired. One condition is added in this patch. The negative rtt value will be filtered out when extracting the common sender info. BUG=webrtc:3377 ========== to ========== Filter out some variables with initial -1 in the stats report. If we call GetStats in PeerConnection before receiving the remote answer, we will get some variables in the StatsReports which are initially set to be -1. Several conditions are added when extracting the info for the report in StatsCollector. Those variables include: gooRtt, dataChannelId, googEchoCancellationEchoDelayMedian, googEchoCancellationEchoQualityMin, googEchoCancellationEchoDelayStdDev, googJitterReceived, audioInputLevel, googCaptureStartNtpTimeMs packetsLost. BUG=webrtc:3377 ==========
lgtm
The CQ bit was checked by zhihuang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875873002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
The CQ bit was checked by zhihuang@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org Link to the patchset: https://codereview.webrtc.org/1875873002/#ps60001 (title: "Fix the unit test after merge.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875873002/60001
Message was sent while issue was closed.
Description was changed from ========== Filter out some variables with initial -1 in the stats report. If we call GetStats in PeerConnection before receiving the remote answer, we will get some variables in the StatsReports which are initially set to be -1. Several conditions are added when extracting the info for the report in StatsCollector. Those variables include: gooRtt, dataChannelId, googEchoCancellationEchoDelayMedian, googEchoCancellationEchoQualityMin, googEchoCancellationEchoDelayStdDev, googJitterReceived, audioInputLevel, googCaptureStartNtpTimeMs packetsLost. BUG=webrtc:3377 ========== to ========== Filter out some variables with initial -1 in the stats report. If we call GetStats in PeerConnection before receiving the remote answer, we will get some variables in the StatsReports which are initially set to be -1. Several conditions are added when extracting the info for the report in StatsCollector. Those variables include: gooRtt, dataChannelId, googEchoCancellationEchoDelayMedian, googEchoCancellationEchoQualityMin, googEchoCancellationEchoDelayStdDev, googJitterReceived, audioInputLevel, googCaptureStartNtpTimeMs packetsLost. BUG=webrtc:3377 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Filter out some variables with initial -1 in the stats report. If we call GetStats in PeerConnection before receiving the remote answer, we will get some variables in the StatsReports which are initially set to be -1. Several conditions are added when extracting the info for the report in StatsCollector. Those variables include: gooRtt, dataChannelId, googEchoCancellationEchoDelayMedian, googEchoCancellationEchoQualityMin, googEchoCancellationEchoDelayStdDev, googJitterReceived, audioInputLevel, googCaptureStartNtpTimeMs packetsLost. BUG=webrtc:3377 ========== to ========== Filter out some variables with initial -1 in the stats report. If we call GetStats in PeerConnection before receiving the remote answer, we will get some variables in the StatsReports which are initially set to be -1. Several conditions are added when extracting the info for the report in StatsCollector. Those variables include: gooRtt, dataChannelId, googEchoCancellationEchoDelayMedian, googEchoCancellationEchoQualityMin, googEchoCancellationEchoDelayStdDev, googJitterReceived, audioInputLevel, googCaptureStartNtpTimeMs packetsLost. BUG=webrtc:3377 Committed: https://crrev.com/6ba3b1976f3d8298450ac89697868d1ee0b6c66a Cr-Commit-Position: refs/heads/master@{#12735} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/6ba3b1976f3d8298450ac89697868d1ee0b6c66a Cr-Commit-Position: refs/heads/master@{#12735} |
